Closed
Bug 1476477
Opened 7 years ago
Closed 7 years ago
Change some nsAutoCString to nsCString to fix -Wreturn-std-move in windows widget
Categories
(Core :: Widget: Win32, enhancement)
Core
Widget: Win32
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: xidorn, Assigned: xidorn)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
nsCString cannot hold stack buffer from nsAutoCString, so it would have to copy and allocate anyway.
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → xidorn+moz
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8992803 [details]
Bug 1476477 - Replace nsAutoCString with nsCString for local result variables in windows widget.
https://reviewboard.mozilla.org/r/257642/#review264556
Attachment #8992803 -
Flags: review?(masayuki) → review+
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7692346c4515
Replace nsAutoCString with nsCString for local result variables in windows widget. r=masayuki
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•