1476507 - Supply an API to draw rounded rectangles in Moz2D

Status: RESOLVED WONTFIX

(Core :: Graphics, enhancement, P3)

Description

[Bas Schouten (:bas.schouten)]

We do a lot of rounded rectangle drawing, right now we create path objects for all of them, this is somewhat silly. We should not.

Comment 1

[Bas Schouten (:bas.schouten)]

Attachment: Bug 1476507 - Part 1: Allow filling rounded rectangles directly in the Moz2D API.

Review commit: https://reviewboard.mozilla.org/r/257696/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/257696/

Comment 2

[Bas Schouten (:bas.schouten)]

Attachment: Bug 1476507 - Part 2: Implement FillRoundedRect for DrawTargetCapture.

Review commit: https://reviewboard.mozilla.org/r/257698/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/257698/

Comment 3

[Bas Schouten (:bas.schouten)]

Attachment: Bug 1476507 - Part 3: Implement FillRoundedRect for DrawTargetD2D1.

Review commit: https://reviewboard.mozilla.org/r/257700/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/257700/

Comment 4

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8992855 [details]
Bug 1476507 - Part 1: Allow filling rounded rectangles directly in the Moz2D API.

https://reviewboard.mozilla.org/r/257696/#review264606

Comment 5

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8992856 [details]
Bug 1476507 - Part 2: Implement FillRoundedRect for DrawTargetCapture.

https://reviewboard.mozilla.org/r/257698/#review264608

::: gfx/2d/DrawTargetD2D1.h:74
(Diff revision 1)
>                             const IntPoint &aDestination) override;
>  
>    virtual void FillRect(const Rect &aRect,
>                          const Pattern &aPattern,
>                          const DrawOptions &aOptions = DrawOptions()) override;
> +  virtual void FillRoundedRect(const RoundedRect &aRect,

These bits were probably meant to be in part 3 I assume.

Comment 6

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8992857 [details]
Bug 1476507 - Part 3: Implement FillRoundedRect for DrawTargetD2D1.

https://reviewboard.mozilla.org/r/257700/#review264610