Closed Bug 1476552 Opened Last year Closed Last year
Minor improvements to Gecko
Session .Web Response Info
46 bytes, text/x-phabricator-request
|Details | Review|
1) WebResponseInfo should be static. Right now it has an implicit reference to the outer class and can access everything in it. However this doesn't seem to be needed. I'm trying to create a WebResponseInfo object in a test case and it's complicated because I need to create it from inside a GeckoSession object and can't create it independently. 2) It looks like only "uri" is a required value. The properties should have a @Nullable or @NonNull annotation to make Kotlin interoperability nicer.
Jim says this would be a good contributor bug. Setting Sebastian as the mentor because he best knows what needs to be fixed.
Priority: -- → P2
Whiteboard: [good first bug]
MozReview-Commit-ID: 1HWEStKaGVl Bug 1476552 part 1 - Add @NonNull/@Nullable annotations to GeckoSession::WebResponseInfo for Kotlin interoperability Bug 1476552 part 2 - Make GeckoSession::WebResponseInfo static MozReview-Commit-ID: 4ce92G7i2nz
I submitted a patch for review here: https://phabricator.services.mozilla.com/D2885
Comment on attachment 8998328 [details] Bug 1476552 - GeckoSession::WebResponseInfo Kotlin annotations and static Sebastian Kaspari (:sebastian) has approved the revision.
Attachment #8998328 - Flags: review+
Assignee: nobody → raynald.mirville
Status: NEW → ASSIGNED
Great! What would be the next step from here?
Jim, Snorp: How do I land phabricator patches? I may have lost commit access since I haven't landed anything in m-c for a while. Can you do that?
You can click the "View in Lando" link and land from there. I took care of it for this patch.
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/a2e7223d34fc GeckoSession::WebResponseInfo Kotlin annotations and static r=sebastian
Thanks for your fix, Raynald! If you're looking for another bug to fix, check out Mozilla's Codetribute bug site. You can search by product and programming language. https://codetribute.mozilla.org/languages/java
You need to log in before you can comment on or make changes to this bug.