1476561 - Autoplay prompt has the wrong icon

Status: RESOLVED FIXED

(Firefox :: Site Identity, defect, P2)

Description

[Dale Harvey (:daleharvey)]

As seem in https://irccloud.mozilla.com/file/Rkb4h0HK/Screen%20Shot%202018-07-18%20at%2010.55.43.png

Comment 1

[Johann Hofmann [:johannh]]

Dale, is this relevant for 62? I.e are you planning on enabling this in 62?

Comment 2

[Dale Harvey (:daleharvey)]

No its looking like 63 for shipping this at the earliest, enabling on nightly shortly though, and will get a patch up for this asap

Comment 3

[Dale Harvey (:daleharvey)]

Attachment: Bug 1476561 - Fix autoplay notification icon.

Review commit: https://reviewboard.mozilla.org/r/258208/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/258208/

Comment 4

[Johann Hofmann [:johannh]]

Comment on attachment 8993509 [details]
Bug 1476561 - Fix autoplay notification icon.

https://reviewboard.mozilla.org/r/258208/#review265328

Great, thanks!

::: browser/base/content/test/popupNotifications/browser_popupNotification_2.js:186
(Diff revision 1)
>        isnot(document.getElementById("geo-notification-icon").boxObject.width, 0,
>              "geo anchor should be visible");
>        goNext();
>      }
>    },
> +  // Test that autoplay media icon is shown

Generally this sort of test should probably live with the other tests that are specific to autoplay (the tests in here are more general tests that popup notifications work), but in this case I don't think it matters :)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c1a1d1e1cfbf
Fix autoplay notification icon. r=johannh

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/c1a1d1e1cfbf