Closed Bug 1476561 Opened Last year Closed Last year

Autoplay prompt has the wrong icon

Categories

(Firefox :: Site Identity, defect, P2)

defect

Tracking

()

RESOLVED FIXED
Firefox 63
Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- unaffected
firefox61 --- unaffected
firefox62 --- disabled
firefox63 --- fixed

People

(Reporter: daleharvey, Assigned: daleharvey)

References

Details

(Keywords: regression)

Attachments

(1 file)

Dale, is this relevant for 62? I.e are you planning on enabling this in 62?
Blocks: 1461656
Flags: needinfo?(dharvey)
Keywords: regression
No its looking like 63 for shipping this at the earliest, enabling on nightly shortly though, and will get a patch up for this asap
Flags: needinfo?(dharvey)
Assignee: nobody → dharvey
Comment on attachment 8993509 [details]
Bug 1476561 - Fix autoplay notification icon.

https://reviewboard.mozilla.org/r/258208/#review265328

Great, thanks!

::: browser/base/content/test/popupNotifications/browser_popupNotification_2.js:186
(Diff revision 1)
>        isnot(document.getElementById("geo-notification-icon").boxObject.width, 0,
>              "geo anchor should be visible");
>        goNext();
>      }
>    },
> +  // Test that autoplay media icon is shown

Generally this sort of test should probably live with the other tests that are specific to autoplay (the tests in here are more general tests that popup notifications work), but in this case I don't think it matters :)
Attachment #8993509 - Flags: review?(jhofmann) → review+
Pushed by dharvey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c1a1d1e1cfbf
Fix autoplay notification icon. r=johannh
https://hg.mozilla.org/mozilla-central/rev/c1a1d1e1cfbf
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
QA Whiteboard: [good first verify]
You need to log in before you can comment on or make changes to this bug.