1476603 - [Static Analysis] DEAD_STORE error in dom/indexedDB/ActorsParent.cpp

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect, P3)

Description

[Robert Bartlensky [:rbartlensky]]

dom/indexedDB/ActorsParent.cpp:3946: error: DEAD_STORE
  The value written to &rv (type int) is never used.
    3944.     UniqueFreePtr<uint8_t> newIdv;
    3945.     uint32_t newIdvLength;
    3946. >   rv = MakeCompressedIndexDataValues(oldIdv, newIdv, &newIdvLength);
    3947.
    3948.     std::pair<uint8_t*, int> data(newIdv.release(), newIdvLength);

Comment 1

[Robert Bartlensky [:rbartlensky]]

Attachment: Bug 1476603: Fix DEAD_STORE error in dom/indexedDB/ActorsParent.cpp.

Review commit: https://reviewboard.mozilla.org/r/258090/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/258090/

Comment 2

[Jan Varga [:janv]]

Comment on attachment 8993313 [details]
Bug 1476603: Fix DEAD_STORE error in dom/indexedDB/ActorsParent.cpp.

https://reviewboard.mozilla.org/r/258090/#review265040

::: dom/indexedDB/ActorsParent.cpp:3946
(Diff revision 1)
>      return rv;
>    }
>  
>    UniqueFreePtr<uint8_t> newIdv;
>    uint32_t newIdvLength;
> -  rv = MakeCompressedIndexDataValues(oldIdv, newIdv, &newIdvLength);
> +  Unused << MakeCompressedIndexDataValues(oldIdv, newIdv, &newIdvLength);

Why not add:
if (NS_WARN_IF(NS_FAILED(rv))) {
  return rv;
}
  
?

Comment 3

[Robert Bartlensky [:rbartlensky]]

Comment on attachment 8993313 [details]
Bug 1476603: Fix DEAD_STORE error in dom/indexedDB/ActorsParent.cpp.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/258090/diff/1-2/

Comment 4

[Jan Varga [:janv]]

Comment on attachment 8993313 [details]
Bug 1476603: Fix DEAD_STORE error in dom/indexedDB/ActorsParent.cpp.

https://reviewboard.mozilla.org/r/258090/#review265044

::: dom/indexedDB/ActorsParent.cpp:3949
(Diff revision 2)
>    UniqueFreePtr<uint8_t> newIdv;
>    uint32_t newIdvLength;
>    rv = MakeCompressedIndexDataValues(oldIdv, newIdv, &newIdvLength);
> -
> +  if (NS_WARN_IF(NS_FAILED(rv))) {
> +    return rv;
> +  }

Nit: add a blank line

Comment 5

[Robert Bartlensky [:rbartlensky]]

Comment on attachment 8993313 [details]
Bug 1476603: Fix DEAD_STORE error in dom/indexedDB/ActorsParent.cpp.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/258090/diff/2-3/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7f73954c5633
Fix DEAD_STORE error in dom/indexedDB/ActorsParent.cpp. r=janv

Comment 7

[Nicholas Nethercote [inactive]]

Comment on attachment 8993313 [details]
Bug 1476603: Fix DEAD_STORE error in dom/indexedDB/ActorsParent.cpp.

https://reviewboard.mozilla.org/r/258090/#review265270

Comment 4 has "Flags: review+" but I don't see it on this attachment. Not sure what's going on, but this clearly doesn't need a review from me at this point.

Comment 8

[Robert Bartlensky [:rbartlensky]]

(In reply to Nicholas Nethercote [:njn] from comment #7)
> Comment on attachment 8993313 [details]
> Bug 1476603: Fix DEAD_STORE error in dom/indexedDB/ActorsParent.cpp.
> 
> https://reviewboard.mozilla.org/r/258090/#review265270
> 
> Comment 4 has "Flags: review+" but I don't see it on this attachment. Not
> sure what's going on, but this clearly doesn't need a review from me at this
> point.

Yes, sorry about that! I put the wrong name in the reviewers section.

Comment 9

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/7f73954c5633