1476644 - [Static Analysis] DEAD_STORE in media/webrtc/signaling/gtest/videoconduit_unittests.cpp

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect, P3)

Description

[Robert Bartlensky [:rbartlensky]]

media/webrtc/signaling/gtest/videoconduit_unittests.cpp:783: error: DEAD_STORE
  The value written to &ec (type int) is never used.
  781.     codecConfig.mSimulcastEncodings.push_back(encoding2);
  782.     codecConfig.mSimulcastEncodings.push_back(encoding3);
  783. >   ec = mVideoConduit->ConfigureCodecMode(webrtc::VideoCodecMode::kScreensharing);
  784.     ec = mVideoConduit->ConfigureSendMediaCodec(&codecConfig);
  785.     ASSERT_EQ(ec, kMediaConduitNoError);

Comment 1

[Robert Bartlensky [:rbartlensky]]

Attachment: Bug 1476644: Fix DEAD_STORE error in media/webrtc/signaling/gtest/videoconduit_unittests.cpp.

Review commit: https://reviewboard.mozilla.org/r/257816/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/257816/

Comment 2

[Eric Rescorla (:ekr)]

Comment on attachment 8993004 [details]
Bug 1476644: Fix DEAD_STORE error in media/webrtc/signaling/gtest/videoconduit_unittests.cpp.

https://reviewboard.mozilla.org/r/257816/#review264752

::: media/webrtc/signaling/gtest/videoconduit_unittests.cpp:785
(Diff revision 1)
>  
>    VideoCodecConfig codecConfig(120, "VP8", constraints);
>    codecConfig.mSimulcastEncodings.push_back(encoding);
>    codecConfig.mSimulcastEncodings.push_back(encoding2);
>    codecConfig.mSimulcastEncodings.push_back(encoding3);
> -  ec = mVideoConduit->ConfigureCodecMode(webrtc::VideoCodecMode::kScreensharing);
> +  Unused << mVideoConduit->ConfigureCodecMode(webrtc::VideoCodecMode::kScreensharing);

Rather than ignoring the return code, you should be checking it, with an ASSERT_EQ() like that on line 785

Comment 3

[Robert Bartlensky [:rbartlensky]]

Comment on attachment 8993004 [details]
Bug 1476644: Fix DEAD_STORE error in media/webrtc/signaling/gtest/videoconduit_unittests.cpp.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/257816/diff/1-2/

Comment 4

[Eric Rescorla (:ekr)]

Comment on attachment 8993004 [details]
Bug 1476644: Fix DEAD_STORE error in media/webrtc/signaling/gtest/videoconduit_unittests.cpp.

https://reviewboard.mozilla.org/r/257816/#review265212

Comment 5

[Andreea Pavel [:apavel]]

:rbrtiensky i tried to land this through mozzreview but i can't it still has an opened issue. 
Please take a look, fix it and then set the checkin-needed.
Thank you

Comment 6

[Robert Bartlensky [:rbartlensky]]

(In reply to Andreea Pavel [:apavel] from comment #5)
> :rbrtiensky i tried to land this through mozzreview but i can't it still has
> an opened issue. 
> Please take a look, fix it and then set the checkin-needed.
> Thank you

Sorry about that, I closed it now.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6259a3d0d8a3
Fix DEAD_STORE error in media/webrtc/signaling/gtest/videoconduit_unittests.cpp. r=ekr

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/6259a3d0d8a3