1476645 - [Static Analysis] infer errors in gfx/*

Status: RESOLVED FIXED

(Core :: Graphics, enhancement, P3)

Description

[Robert Bartlensky [:rbartlensky]]

gfx/thebes/gfxFontUtils.cpp:93: error: DEAD_STORE
  The value written to &index (type int) is never used.
  91.               if (i + 4 != 32) index += snprintf(&outStr[index], BUFSIZE - index, " ");
  92.           }
  93. >         index += snprintf(&outStr[index], BUFSIZE - index, "]");
  94.           LOG(aWhichLog, ("%s", outStr));
  95.       }

gfx/2d/FilterProcessingSIMD-inl.h:119: error: DEAD_STORE
  The value written to &bgrabgrabgrabgra1 (type void) is never used.
  117.         int32_t targetIndex = y * alphaStride + x;
  118.
  119. >       u8x16_t bgrabgrabgrabgra1 = simd::FromZero8<u8x16_t>();
  120.         u8x16_t bgrabgrabgrabgra2 = simd::FromZero8<u8x16_t>();
  121.         u8x16_t bgrabgrabgrabgra3 = simd::FromZero8<u8x16_t>();


gfx/src/nsDeviceContext.cpp:274: error: DEAD_STORE
  The value written to &dpi (type float) is never used.
  272.   nsDeviceContext::SetDPI(double* aScale)
  273.   {
  274. >     float dpi = -1.0f;
  275.
  276.       // Use the printing DC to determine DPI values, if we have one.

gfx/src/nsDeviceContext.cpp:549: error: DEAD_STORE
  The value written to &rv (type int) is never used.
  547.                  "Mismatched BeginDocument/EndDocument calls");
  548.
  549. >     nsresult rv = NS_OK;
  550.
  551.       mIsCurrentlyPrintingDoc = false;

gfx/2d/FilterProcessingSIMD-inl.h:804: error: DEAD_STORE
  The value written to &bgrabgrabgrabgra1 (type void) is never used.
  802.         int32_t targetIndex = y * channelStride + x;
  803.
  804. >       u8x16_t bgrabgrabgrabgra1 = simd::FromZero8<u8x16_t>();
  805.         u8x16_t bgrabgrabgrabgra2 = simd::FromZero8<u8x16_t>();
  806.         u8x16_t bgrabgrabgrabgra3 = simd::FromZero8<u8x16_t>();

Comment 1

[Robert Bartlensky [:rbartlensky]]

Attachment: Bug 1476645: Fix DEAD_STORE errors in gfx/*.

Review commit: https://reviewboard.mozilla.org/r/257820/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/257820/

Comment 2

[Lee Salzman [:lsalzman]]

Comment on attachment 8993036 [details]
Bug 1476645: Fix DEAD_STORE errors in gfx/*.

https://reviewboard.mozilla.org/r/257820/#review264758

Comment 3

[Robert Bartlensky [:rbartlensky]]

Comment on attachment 8993036 [details]
Bug 1476645: Fix DEAD_STORE errors in gfx/*.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/257820/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/75cbc42803d7
Fix DEAD_STORE errors in gfx/*. r=lsalzman

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/75cbc42803d7