1476657 - [Static Analysis] DEAD_STORE errors in js/src/frontend/Parser.cpp

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P3)

Description

[Robert Bartlensky [:rbartlensky]]

js/src/frontend/Parser.cpp:1837: error: DEAD_STORE
  The value written to &cursor (type js::BindingName*) is never used.
  1835.
  1836.           bindings->constStart = cursor - start;
  1837. >         cursor = FreshlyInitializeBindings(cursor, consts);
  1838.
  1839.           bindings->length = numBindings;

js/src/frontend/Parser.cpp:1907: error: DEAD_STORE
  The value written to &cursor (type js::BindingName*) is never used.
  1905.
  1906.           bindings->constStart = cursor - start;
  1907. >         cursor = FreshlyInitializeBindings(cursor, consts);
  1908.
  1909.           bindings->length = numBindings;

js/src/frontend/Parser.cpp:1947: error: DEAD_STORE
  The value written to &cursor (type js::BindingName*) is never used.
  1945.           BindingName* cursor = start;
  1946.
  1947. >         cursor = FreshlyInitializeBindings(cursor, vars);
  1948.
  1949.           bindings->length = numBindings;

js/src/frontend/Parser.cpp:2046: error: DEAD_STORE
  The value written to &cursor (type js::BindingName*) is never used.
  2044.
  2045.           bindings->varStart = cursor - start;
  2046. >         cursor = FreshlyInitializeBindings(cursor, vars);
  2047.
  2048.           bindings->length = numBindings;

js/src/frontend/Parser.cpp:2087: error: DEAD_STORE
  The value written to &cursor (type js::BindingName*) is never used.
  2085.           BindingName* cursor = start;
  2086.
  2087. >         cursor = FreshlyInitializeBindings(cursor, vars);
  2088.
  2089.           bindings->length = numBindings;

js/src/frontend/Parser.cpp:2144: error: DEAD_STORE
  The value written to &cursor (type js::BindingName*) is never used.
  2142.
  2143.           bindings->constStart = cursor - start;
  2144. >         cursor = FreshlyInitializeBindings(cursor, consts);
  2145.
  2146.           bindings->length = numBindings;

js/src/frontend/Parser.cpp:4857: error: DEAD_STORE
  The value written to &declKind (type int) is never used.
  4855.               // Annex B.3.5 has different early errors for vars in for-of loops.
  4856.               if (declKind == DeclarationKind::Var)
  4857. >                 declKind = DeclarationKind::ForOfVar;
  4858.           } else {
  4859.               *forHeadKind = ParseNodeKind::ForHead;

Comment 1

[Robert Bartlensky [:rbartlensky]]

Attachment: Bug 1476657: Fix DEAD_STORE issues in js/src/frontend/Parser.cpp.

Review commit: https://reviewboard.mozilla.org/r/257854/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/257854/

Comment 2

[Tooru Fujisawa [:arai]]

Comment on attachment 8993048 [details]
Bug 1476657: Fix DEAD_STORE issues in js/src/frontend/Parser.cpp.

https://reviewboard.mozilla.org/r/257854/#review264852

Thanks!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d259e78aa9c
Fix DEAD_STORE issues in js/src/frontend/Parser.cpp. r=arai

Comment 4

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a88fbbebadcc
Backed out changeset 6d259e78aa9c for bustage in /builds/worker/workspace/build/src/js/src/frontend/Parser.cpp on a CLOSED TREE

Comment 5

[Robert Bartlensky [:rbartlensky]]

It seems that someone solved the issues already.

Comment 6

[Robert Bartlensky [:rbartlensky]]

My bad, my tree wasn't merged properly...

Comment 7

[Robert Bartlensky [:rbartlensky]]

Comment on attachment 8993048 [details]
Bug 1476657: Fix DEAD_STORE issues in js/src/frontend/Parser.cpp.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/257854/diff/1-2/

Comment 8

[Robert Bartlensky [:rbartlensky]]

Comment on attachment 8993048 [details]
Bug 1476657: Fix DEAD_STORE issues in js/src/frontend/Parser.cpp.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/257854/diff/2-3/

Comment 9

[Robert Bartlensky [:rbartlensky]]

I added 'Unused << ' everywhere, could you confirm that it is fine?

Comment 10

[Tooru Fujisawa [:arai]]

yes, looks good :)

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/358b59601fb9
Fix DEAD_STORE issues in js/src/frontend/Parser.cpp. r=arai

Comment 12

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/358b59601fb9