1476664 - The searched string is not displayed as highlighted above the "Add" button in the preferences page

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P3)

Description

[Maria Berlinger [:mberlinger], Services QA]

Attachment: Search bug.mov

[Affected versions]:
Firefox 63.0a1 (BuildId:20180718100918).
Firefox 62.0b9 (BuildId:20180713213322).
Firefox 61.0.1 (BuildId:20180704003137).

[Unaffected versions]:
Firefox 60.1.0 esr (BuildId:20180621121604).

[Affected platforms]:
Windows 10 64bit.
macOS 10.13.4
Ubuntu 16.04 64bit.

[Steps to reproduce]:
1. Launch Firefox.
2. Go to about:preferences.
3. Write "Organiza" in the "Find in options" search field.
4. Go to "Saved Addresses".

[Expected result]:
The string entered in step 3 is displayed as highlighted above the "Add" button in the "Saved Addresses" panel.

[Actual result]:
The searched string is not displayed as highlighted above the "Add" button.

[Regression range]:
This seems to be a regression:
Last good revision: e62d73ef396c32ca930897eb95d328e2ac15a901
First bad revision: a831178ed112be4db3c867876b99e61d22bdbc7a

Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e62d73ef396c32ca930897eb95d328e2ac15a901&tochange=a831178ed112be4db3c867876b99e61d22bdbc7a

[Additional information]:
For further information regarding this issue please observe the attached screencast.
Please note that the searched string is displayed highlighted above the "Add" button only after accessing the "Add New Address" panel by clicking the "Add" button and going back to the "Saved Addresses" panel again via the "Cancel" button.

Comment 1

[Maria Berlinger [:mberlinger], Services QA]

Hi Zibi!

Can you please have a look into this?

Thanks!

Comment 2

[:Gijs (he/him)]

The grapevine mentioned a day or two that gandalf is/was on PTO. Jared, could you take a look? AFAICT we're shipping this in the US, but I know very little about it as I never see it, given we don't ship it in most other places. It's not as trivial as I first thought, because the form fill dialog is written in HTML so it's not just a question of missing fluent IDs or something...

Comment 3

[Pascal Chevrel:pascalc]

Gandalf, Jared, any update on this issue?

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

These formfill dialogs don't use Fluent. Switching over to Fluent should fix it and would be the right direction to move. This appears to only affect the formfill dialogs.

Comment 5

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Too late to fix in 63. We could still take a patch for 65 and potentially for 64.

Comment 6

[kpatenio]

Attachment: WIP: Bug 1476664 - fix searched string not appearing above Add button in about:preferences

Comment 7

[kpatenio]

Attachment: Bug 1476664 - fix search term tooltip for Add button in saved addresses dialog

Comment 8

[kpatenio]

Submitted a new WIP patch addressing the issue.

It appears that this bug occurs due to the way we call searchWithinNode before creating the tooltips for the Add button (it is an asynchronous function).

Fluent migrations will not be made for this fix.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c2a16b8370fe
fix search term tooltip for Add button in saved addresses dialog r=preferences-reviewers,jaws

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/c2a16b8370fe