Closed Bug 1476673 Opened 7 years ago Closed 6 years ago

-Wlarge-by-value-copy warnings on WebVR

Categories

(Core :: WebVR, defect, P3)

Product:
Core
Component:
WebVR
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox63 --- affected

People

(Reporter: Sylvestre, Unassigned)

References

(Blocks 1 open bug)

Details

VRDisplayClient.cpp:272, Clang (LLVM based), Priority: Normal return value of 'GetSensorState' is a large (224 bytes) pass-by-value object; pass it by reference instead ? gfxVRExternal.cpp:96, Clang (LLVM based), Priority: Normal return value of 'GetSensorState' is a large (224 bytes) pass-by-value object; pass it by reference instead ? gfxVROSVR.cpp:300, Clang (LLVM based), Priority: Normal return value of 'GetSensorState' is a large (224 bytes) pass-by-value object; pass it by reference instead ? gfxVROpenVR.cpp:251, Clang (LLVM based), Priority: Normal return value of 'GetSensorState' is a large (224 bytes) pass-by-value object; pass it by reference instead ? gfxVRPuppet.cpp:154, Clang (LLVM based), Priority: Normal return value of 'GetSensorState' is a large (224 bytes) pass-by-value object; pass it by reference instead ?

The code involved in the gfxVROSVR and gfxVROpenVR cases has been removed already.
The gfxVRPuppet case will be removed as part of refactoring in Bug 1466702.
The VRDisplayClient case would be a "good first bug" candidate.

Depends on: 1473402, 1466702
Priority: -- → P3

The VRDisplayClient case has been fixed in Bug 1508225.
gfxVRPuppet, gfxVRExternal, gfxVROSVR, gfxVROpenVR have been removed in Bug 1466702.

Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.