1476673 - -Wlarge-by-value-copy warnings on WebVR

Status: RESOLVED FIXED

(Core :: WebVR, defect, P3)

Description

[Sylvestre Ledru [:Sylvestre]]

VRDisplayClient.cpp:272, Clang (LLVM based), Priority: Normal
return value of 'GetSensorState' is a large (224 bytes) pass-by-value object; pass it by reference instead ?

gfxVRExternal.cpp:96, Clang (LLVM based), Priority: Normal
return value of 'GetSensorState' is a large (224 bytes) pass-by-value object; pass it by reference instead ?

gfxVROSVR.cpp:300, Clang (LLVM based), Priority: Normal
return value of 'GetSensorState' is a large (224 bytes) pass-by-value object; pass it by reference instead ?

gfxVROpenVR.cpp:251, Clang (LLVM based), Priority: Normal
return value of 'GetSensorState' is a large (224 bytes) pass-by-value object; pass it by reference instead ?

gfxVRPuppet.cpp:154, Clang (LLVM based), Priority: Normal
return value of 'GetSensorState' is a large (224 bytes) pass-by-value object; pass it by reference instead ?

Comment 1

[:kip (Kearwood Gilbert)]

The code involved in the gfxVROSVR and gfxVROpenVR cases has been removed already.
The gfxVRPuppet case will be removed as part of refactoring in Bug 1466702.
The VRDisplayClient case would be a "good first bug" candidate.

Comment 2

[:kip (Kearwood Gilbert)]

The VRDisplayClient case has been fixed in Bug 1508225.
gfxVRPuppet, gfxVRExternal, gfxVROSVR, gfxVROpenVR have been removed in Bug 1466702.