1476678 - Remove document.persist from XULDocument

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P3)

Description

[Brian Grinstead [:bgrins]]

Once Bug 1476030 lands, we aren't going to be using it anymore (instead using Services.xulStore.persist).

Comment 1

[Jorg K (CEST = GMT+2)]

Thanks for the heads up, I filed bug 1476760 for TB. We've got time until this bug here lands, right?

Comment 2

[Brian Grinstead [:bgrins]]

(In reply to Jorg K (GMT+2) from comment #1)
> Thanks for the heads up, I filed bug 1476760 for TB. We've got time until
> this bug here lands, right?

Yes - I'd like to get a patch up relatively shortly to prevent accidentally re-introducing callers, but there'll be a gap between Bug 1476030 landing and this.

Comment 3

[Brian Grinstead [:bgrins]]

Attachment: Bug 1476678 - Remove document.persist from XULDocument;

Also remove overload for XULDocument::Persist and the implementation
of XULDocument::DoPersist, since there's only one remaining caller.

Review commit: https://reviewboard.mozilla.org/r/258564/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/258564/

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8993956 [details]
Bug 1476678 - Remove document.persist from XULDocument;

https://reviewboard.mozilla.org/r/258564/#review265948

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf969e57bc7b
Remove document.persist from XULDocument;r=bz

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/cf969e57bc7b