1476710 - Crash in java.lang.IllegalStateException: FragmentManager is already executing transactions at android.support.v4.app.FragmentManagerImpl.ensureExecReady(FragmentManager.java)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Marcia Knous [:marcia]]

This bug was filed from the Socorro interface and is
report bp-054abb3e-dd18-4596-8857-f7ab00180718.
=============================================================

Unsure where to file this, but this might be another regression from the API 26 work: https://bit.ly/2msCYDN.

One comment: crashed on first opening. 

Top 10 frames of crashing thread:

0 libxul.so GeckoAppShellSupport::ReportJavaCrash widget/android/nsAppShell.cpp:280
1 libxul.so void mozilla::jni::NativeStub<mozilla::java::GeckoAppShell::ReportJavaCrash_t, GeckoAppShellSupport, mozilla::jni::Args<mozilla::jni::Ref<mozilla::jni::TypedObject<_jthrowable*>, _jthrowable*> const&, mozilla::jni::StringParam const&> >::Wrap<&GeckoAppShellSupport::ReportJavaCrash> widget/android/jni/Natives.h:778
2 base.odex base.odex@0xba26b 
3 dalvik-LinearAlloc (deleted) dalvik-LinearAlloc @0x4f2a 
4 dalvik-main space (region space) (deleted) dalvik-main space @0x142f116 
5 dalvik-main space (region space) (deleted) dalvik-main space @0x205cf6 
6 dalvik-main space (region space) (deleted) dalvik-main space @0x254db6 
7 libart.so libart.so@0x3dcce1 
8 dalvik-main space (region space) (deleted) dalvik-main space @0x205cf6 
9 dalvik-main space (region space) (deleted) dalvik-main space @0x254db6 

=============================================================

Comment 1

[Marcia Knous [:marcia]]

From the top part of the Java stack:

java.lang.IllegalStateException: FragmentManager is already executing transactions
	at android.support.v4.app.FragmentManagerImpl.ensureExecReady(FragmentManager.java:2167)
	at android.support.v4.app.FragmentManagerImpl.execPendingActions(FragmentManager.java:2223)
	at android.support.v4.app.FragmentManagerImpl.popBackStackImmediate(FragmentManager.java:819)
	at org.mozilla.gecko.tabs.TabHistoryFragment.dismiss(TabHistoryFragment.java:147)
	at org.mozilla.gecko.tabs.TabHistoryFragment.onPause(TabHistoryFragment.java:108)
	at android.support.v4.app.Fragment.performPause(Fragment.java:2542)
	at android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:1476)
	at android.support.v4.app.FragmentManagerImpl.moveFragmentToExpectedState(FragmentManager.java:1740)
	at android.support.v4.app.BackStackRecord.executePopOps(BackStackRecord.java:853)
	at android.support.v4.app.FragmentManagerImpl.executeOps(FragmentManager.java:2577)
	at android.support.v4.app.FragmentManagerImpl.executeOpsTogether(FragmentManager.java:2367)
	at android.support.v4.app.FragmentManagerImpl.removeRedundantOperationsAndExecute(FragmentManager.java:2322)
	at android.support.v4.app.FragmentManagerImpl.popBackStackImmediate(FragmentManager.java:851)
	at android.support.v4.app.FragmentManagerImpl.popBackStackImmediate(FragmentManager.java:794)
	at android.support.v4.app.FragmentActivity.onBackPressed(FragmentActivity.java:174)

Comment 2

[Marcia Knous [:marcia]]

Currently the #5 top browser crash on nightly.

Comment 3

[Ian Moody [:Kwan] (UTC+1)]

I can repro this seemingly reliably by holding the phone's back button to bring up the menu, then hitting back again.

bp-8ee5ea2c-eeeb-42d3-b05b-bb4d10180720

Comment 4

[Marcia Knous [:marcia]]

(In reply to Ian Moody [:Kwan] (UTC+0) from comment #3)
> I can repro this seemingly reliably by holding the phone's back button to
> bring up the menu, then hitting back again.
> 
> bp-8ee5ea2c-eeeb-42d3-b05b-bb4d10180720

Thanks for the STR! I can also reproduce on my Pixel 2 100% with these steps.

Comment 5

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1476710 - Use childFragmentmanager when dismissing TabHistoryFragment;

Review commit: https://reviewboard.mozilla.org/r/258974/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/258974/

Comment 6

[Ioana Chiorean]

Also reproducing with the STR. Petru feel free to Ni me when you have the fix.

Comment 7

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8994420 [details]
Bug 1476710 - Use childFragmentmanager when dismissing TabHistoryFragment;

https://reviewboard.mozilla.org/r/258974/#review266468

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/78a98c31897a
Use childFragmentmanager when dismissing TabHistoryFragment; r=jchen

Comment 9

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/78a98c31897a

Comment 10

[Petru-Mugurel Lingurar [:petru]]

Next Nightly build will contains my patch.
Would appreciate if you could test to see if the issue was fixed.

Comment 11

[Chris Peterson [:cpeterson]]

Fennec <= 62 is unaffected because this is a regression from the API 26 work in 63 Nightly.

Comment 12

[Oana Horvath [:ohorvath]]

Verified as fixed on Nightly 63 with the STR in comment 3.
Devices:
Huawei Nexus 6P (Android 8.1.0)
Samsung Galaxy Tab 3 (Android 8.0)
Google Pixel (Android P Beta)
HTC Desire 820 (Android 6.0.1)