1476715 - Differentiate between firstparty/thirdparty or thirdparty tracking channels

Status: RESOLVED FIXED

(Firefox :: Protections UI, defect, P1)

Description

[(no longer active)]

The third part of bug 1476324 added an unintended regression that causes all features that use TP annotations on channels to be applied to first party contexts.

Instead, it would be nice to fix things by removing the GetIsTrackingResource() getter from the channel interface and add two new ones, GetIsThirdPartyTrackingResource() and GetIsFirstPartyOrThirdPartyTrackingResource().  The latter method can do what GetIsTrackingResource() currently does and the former can check mozIThirdPartyUtils::IsThirdPartyChannel() additionally.

Comment 1

[Andrea Marchesini [:baku]]

I went through all the isTrackingResource and GetIsTrackingResource() calls and I don't see any valid reason to split this attribute in 2: isFirstPartyTrackingResource and isThirdPartyResource.

Instead, we should probably add a 3rd party check here:

https://searchfox.org/mozilla-central/rev/88199de427d3c5762b7f3c2a4860c10734abd867/netwerk/protocol/http/nsHttpChannel.cpp#573-574

and here:

https://searchfox.org/mozilla-central/rev/88199de427d3c5762b7f3c2a4860c10734abd867/netwerk/protocol/http/nsHttpChannel.cpp#2182-2185

The non-anti-tracking-related call is in ScriptLoader, but this is not really a issue because a script cannot be a first party channel.

I'm going to upload a patch that compiles to show that, this approach is probably not needed.

Comment 2

[Andrea Marchesini [:baku]]

Attachment: tracking.patch

Comment 3

[François Marier [:francois]]

(In reply to Andrea Marchesini [:baku] from comment #1)
> The non-anti-tracking-related call is in ScriptLoader, but this is not
> really a issue because a script cannot be a first party channel.

I can also think of another existing user:

https://searchfox.org/mozilla-central/rev/d4b9e50875ad7e5d20f2fee6a53418315f6dfcc0/netwerk/base/nsChannelClassifier.cpp#1028-1030
https://searchfox.org/mozilla-central/rev/d4b9e50875ad7e5d20f2fee6a53418315f6dfcc0/netwerk/base/nsChannelClassifier.cpp#238

and of a future one: Fastblock (bug 1474280).

Comment 4

[Andrea Marchesini [:baku]]

Attachment: tracking2.patch

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cb8a7a9f4a73
low priority connection for 3rd party + tracking resource only, r=francois

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/cb8a7a9f4a73