Wrong icon size is chosen for browserAction in the Overflow Menu

VERIFIED FIXED in Firefox 63

Status

VERIFIED FIXED
8 months ago
7 months ago

People

(Reporter: Oriol, Assigned: Oriol)

Tracking

unspecified
mozilla63

Firefox Tracking Flags

(firefox61 wontfix, firefox62 wontfix, firefox63 fixed)

Details

Attachments

(3 attachments)

(Assignee)

Description

8 months ago
1. Install https://bugzilla.mozilla.org/attachment.cgi?id=8992085 in about:debugging
2. Right-click the browserAction and choose 'Pin to Overflow Menu'
3. Open the Overflow Menu

The 32px icon is used but the real size is 16px.

This makes my Tab Counter Plus icon look blurry in the Overflow Menu.
Comment hidden (mozreview-request)
(Assignee)

Comment 2

8 months ago
It seems 32px were used in bug 1272222 because back then the Australis menu really had 32px icons. This is no longer the case in Quantum.

Comment 3

8 months ago
mozreview-review
Comment on attachment 8993180 [details]
Bug 1476818 - Choose right add-on icon size for browserAction in the Overflow Menu

https://reviewboard.mozilla.org/r/257986/#review265444

::: browser/components/extensions/parent/ext-browserAction.js:487
(Diff revision 1)
>      let icon16 = IconDetails.getPreferredIcon(icons, this.extension, 16).icon;
>      let icon32 = IconDetails.getPreferredIcon(icons, this.extension, 32).icon;

I wish there was some way to deal with the size than hard coding it.
Attachment #8993180 - Flags: review?(mixedpuppy) → review+
(Assignee)

Updated

8 months ago
Keywords: checkin-needed

Comment 4

8 months ago
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ccee0cdce495
Choose right add-on icon size for browserAction in the Overflow Menu r=mixedpuppy
Keywords: checkin-needed

Comment 5

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ccee0cdce495
Status: ASSIGNED → RESOLVED
Last Resolved: 8 months ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63

Comment 6

7 months ago
Verified using FF 61.0.1 and Nightly 63.0a1 running on Ubuntu 18.04. 
The issue was not reproducible on 63, only on 61. - 08/14/2018
Status: RESOLVED → VERIFIED
status-firefox61: --- → affected

Comment 7

7 months ago
Posted image 61.png

Comment 8

7 months ago
Posted image Nightly.png
status-firefox61: affected → wontfix
status-firefox62: --- → wontfix
You need to log in before you can comment on or make changes to this bug.