1476818 - Wrong icon size is chosen for browserAction in the Overflow Menu

Status: VERIFIED FIXED

(WebExtensions :: Frontend, defect)

Description

[Oriol Brufau [:Oriol]]

1. Install https://bugzilla.mozilla.org/attachment.cgi?id=8992085 in about:debugging
2. Right-click the browserAction and choose 'Pin to Overflow Menu'
3. Open the Overflow Menu

The 32px icon is used but the real size is 16px.

This makes my Tab Counter Plus icon look blurry in the Overflow Menu.

Comment 1

[Oriol Brufau [:Oriol]]

Attachment: Bug 1476818 - Choose right add-on icon size for browserAction in the Overflow Menu

Review commit: https://reviewboard.mozilla.org/r/257986/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/257986/

Comment 2

[Oriol Brufau [:Oriol]]

It seems 32px were used in bug 1272222 because back then the Australis menu really had 32px icons. This is no longer the case in Quantum.

Comment 3

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8993180 [details]
Bug 1476818 - Choose right add-on icon size for browserAction in the Overflow Menu

https://reviewboard.mozilla.org/r/257986/#review265444

::: browser/components/extensions/parent/ext-browserAction.js:487
(Diff revision 1)
>      let icon16 = IconDetails.getPreferredIcon(icons, this.extension, 16).icon;
>      let icon32 = IconDetails.getPreferredIcon(icons, this.extension, 32).icon;

I wish there was some way to deal with the size than hard coding it.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ccee0cdce495
Choose right add-on icon size for browserAction in the Overflow Menu r=mixedpuppy

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ccee0cdce495

Comment 6

[Vlad Jiman]

Verified using FF 61.0.1 and Nightly 63.0a1 running on Ubuntu 18.04. 
The issue was not reproducible on 63, only on 61. - 08/14/2018

Comment 7

[Vlad Jiman]

Attachment: 61.png

Comment 8

[Vlad Jiman]

Attachment: Nightly.png