1476833 - Wrong indicated number of tabs to close

Status: RESOLVED INVALID

(Firefox :: Tabbed Browser, defect, P2)

Description

[Ed Lee :Mardak]

Might be related to bug 1475693 comment 2 as I ran into this when using keyboard shortcuts to switch tabs.

1. Open a new window
2. Open 2 new tabs
3. Cmd-click the middle tab
4. Switch to the first tab (Cmd-1 or Ctrl-tab)
5. Cmd-w close tab

actual: "You are about to close 2 tabs. Are you sure you want to continue?"
expected: "close 3 tabs"

Unless it's supposed to only close the 2 selected tabs and leave the first tab…?

Comment 1

[Abdoulaye O. LY]

I curiously have "close 3 tabs" instead of 2 tabs like you. I wonder if I reproduce it the way you expect it.
Let me repeat the step with a bit more details.

1. Open a new window
 At this point we have a window with only one tab.
2. Open 2 new tabs
 Now we have overall 3 tabs (let's call them A,B and C).
 C is active (showing)
3. Select tab in the middle (B) with Ctrl-click
 Still we have C as the active tab.
 Two tabs selected: B and C
4. Switch to the first tab with Ctrl-tab
 Now A is active
 selected tabs are A,B and C.
5. Ctrl-w 
 Warning popup with 3 tabs to close.

Do I miss something Ed?

In Anyway, this should be fixed with new filed bug 1476844.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

I am able to reproduce Ed's result (running 63.0a1 (2018-07-17) (64-bit) on Windows). I tried both Ctrl+1 and Ctrl+Tab.

Comment 3

[Ed Lee :Mardak]

Attachment: video STR

The steps you describe seem to match up. Here's a video. Maybe it's mac specific?

Comment 4

[Abdoulaye O. LY]

Thanks Ed. 
Indeed, Jared has confirmed this. This will be fixed very soon with bug 1476844.

Comment 5

[Abdoulaye O. LY]

This should be fixed with bug 1476844.

Can you confirm that?

Comment 6

[Damira Akh]

Build ID 	20180926142055
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:64.0) Gecko/20100101 Firefox/64.0

Tested on latest Nightly and only one tab is getting closed.
Followed following steps:

1.Open a new window ---> At this point we have a window with only one tab.
2. Open 2 new tabs ---> Now we have overall 3 tabs (let's call them A,B and C). C is active (showing)
3. Select tab in the middle (B) with Ctrl-click --> Still we have C as the active tab. Two tabs selected: B and C
4. Switch to the first tab with Ctrl-tab
 Now A is active selected tabs is only  A
5. Ctrl-w __> closed only tab A.

Comment 7

[Abdoulaye O. LY]

Yes Damira, this is the correct behaviour. Whenever tab switch is done via Ctrl-tab the selection gets cleared. See Bug 1476844

Comment 8

[Damira Akh]

(In reply to Abdoulaye O. LY from comment #7)
> Yes Damira, this is the correct behaviour. Whenever tab switch is done via
> Ctrl-tab the selection gets cleared. See Bug 1476844

OK Thanks for the clarification.