1476846 - Reduce latency of applying async images of video

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Sotaro Ikeda [:sotaro]]

async images of video is applied with latency with async scene build. It is better to reduce the latency.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Reduce latency of applying async images of video

Comment 2

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=134fc60bb4a4fe07034c36d0deea8e9401896b70

Comment 3

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b0828e57feeda7640c3d4e5eb767146e8a067d11

Comment 4

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Reduce latency of applying async images of video

Rebased.

Comment 5

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fbcd3ada7761c7c3ba9b59f0e6653e1bfcbed20c

Comment 6

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4b6fe72e8487051d46d0154666a9b282df4d2686

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/738e88d3b78e
Reduce latency of applying async images of video r=nical

Comment 8

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8995854 [details] [diff] [review]
patch - Reduce latency of applying async images of video

Review of attachment 8995854 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/wr/AsyncImagePipelineManager.cpp
@@ +355,5 @@
>      // We may, however, have updated some resources.
> +
> +    // Use transaction of scene builder thread to notify epoch.
> +    // It is for making epoc update consisitent.
> +    aMaybeFastTxn.UpdateEpoch(aPipelineId, aEpoch);

This part doesn't seem right. The comment says you're using the scene builder transaction, but the code is using the fast transaction which goes on the RB thread. Also typos: s/epoc/epoch/ and s/consisitent/consistent/

Comment 9

[Kartikaya Gupta (email:[e-mail])]

^

Comment 10

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/738e88d3b78e

Comment 11

[Sotaro Ikeda [:sotaro]]

Thanks for checking!

Comment 12

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Fix UpdateEpoch() handling

Comment 13

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d8547ca2bf44e1966b5a1e01f2e9ac7ea1922d6e

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/aab1cac9daa8
Fix UpdateEpoch() handling r=nical

Comment 15

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/aab1cac9daa8