1476876 - Make FlushRendering async if DComp is used on Windows with WebRender

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Sotaro Ikeda [:sotaro]]

Since Bug 1380462, FlushRendering is always sync. But with WebRender, it seems possible to became async again if possible.

Comment 1

[Sotaro Ikeda [:sotaro]]

When layers.force-synchronous-resize was false and dcomp was disabled , attachment 8885890 [details] caused jiggle during resizing. But when dcomp was enabled, attachment 8885890 [details] did not cause the problem.

Comment 2

[Sotaro Ikeda [:sotaro]]

When dcomp was enabled, it also enables compositor window in gpu process. It might be related.

Comment 3

[Sotaro Ikeda [:sotaro]]

Only using compositor window suppressed majority of jiggles, but I saw jiggle a few times. But with "dcomp + compositor window", I did not saw the jiggles.

Comment 4

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Make FlushRendering async if DComp is used on Windows with WebRender

Comment 5

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Make FlushRendering async if DComp is used on Windows with WebRender

Comment 6

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Make FlushRendering async if DComp is used on Windows with WebRender

Comment 7

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9a00d855ba5bab1cf4ea541b051bdec6efcd2002

Comment 8

[Sotaro Ikeda [:sotaro]]

attachment 8993279 [details] [diff] [review] addressed the problem for me. I checked it on my 2 Windows 10 PCs.

Comment 9

[Nicolas Silva [:nical]]

Comment on attachment 8993279 [details] [diff] [review]
patch - Make FlushRendering async if DComp is used on Windows with WebRender

Review of attachment 8993279 [details] [diff] [review]:
-----------------------------------------------------------------

The review is purely on the cosmetic side of things since I don't know how direct composition affects resize synchronization.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/94fe6b1becfa
Make FlushRendering async if DComp is used on Windows with WebRender r=nical

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/94fe6b1becfa