1476889 - Update autoplay exceptions copy

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Dale Harvey (:daleharvey)]

The copy for the autoplay exceptions dialog needs updated

Comment 1

[Dale Harvey (:daleharvey)]

Bryant if you could update here when you get it, thanks

Comment 2

[Johann Hofmann [:johannh]]

You mean the dialog in about:preferences, right?

Comment 3

[Dale Harvey (:daleharvey)]

Yup, cheers

Comment 4

[Bryant Mao [:bryantmao]]

(In reply to Dale Harvey (:daleharvey) from comment #1)
> Bryant if you could update here when you get it, thanks

Sure, below is the updated copy

For exception dialog https://mozilla.invisionapp.com/share/N2MD6ZV8CMG#/306583373_6-3

1.Description: "You can specify which websites are always or never allowed to autoplay media with sound. Type the address of the site you want to manage and then click Block or Allow."

2.Buttons below the address bar: [Block] [Allow]

3.Website status: [Block] or [Allow]

For global settings https://mozilla.invisionapp.com/share/N2MD6ZV8CMG#/306583372_6-2

1.Combo box: [Allow Autoplay] or [Always Ask] or [Don't Autoplay]

Comment 6

[Dale Harvey (:daleharvey)]

Flod, in the above spec those strings are being changed to 

"Allow Autoplay" | "Dont allow" 

https://mozilla.invisionapp.com/share/N2MD6ZV8CMG#/screens/306583371

From your comment in 1477231 would Allow | Dont allow be better (same as webrtc), the other uses of autoplay dont have the same size issues as far as I can tell

Comment 7

[Francesco Lodolo [:flod]]

(In reply to Dale Harvey (:daleharvey) from comment #6)
> From your comment in 1477231 would Allow | Dont allow be better (same as
> webrtc), the other uses of autoplay dont have the same size issues as far as
> I can tell

Likely yes, since there's no "autoplay". But IMO we should also fix the underlying layout issue, which is letting the button label wrap.

Comment 8

[Dale Harvey (:daleharvey)]

Hey Bryant, could you confirm with the copywriter that |Allow| |Don't Allow| would be suitable for the doorhanger buttons @ https://mozilla.invisionapp.com/share/N2MD6ZV8CMG#/screens/306583371

Cheers

Comment 9

[Dale Harvey (:daleharvey)]

Attachment: Bug 1476889 - Update autoplay copy.

Review commit: https://reviewboard.mozilla.org/r/258774/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/258774/

Comment 10

[Dale Harvey (:daleharvey)]

So as far as I can tell we cant actually wrap text here since its inside a xul:button, we could replace the fact they are buttons but that would be a bigger change and dont allow | allow is consistent with other uses of the doorhanger so I dont think its a large problem

Comment 11

[Francesco Lodolo [:flod]]

Comment on attachment 8994162 [details]
Bug 1476889 - Update autoplay copy.

https://reviewboard.mozilla.org/r/258774/#review265654

Unfortunately all string IDs need to change at this point
https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_content_best_practices#Changing_existing_strings

::: browser/locales/en-US/browser/preferences/permissions.ftl:104
(Diff revision 1)
>  ## Exceptions - Autoplay Media
>  
>  permissions-exceptions-autoplay-media-window =
>      .title = Allowed Websites - Autoplay
>      .style = { permissions-window.style }
> -permissions-exceptions-autoplay-media-desc = You can specify which websites are allowed to automatically play media elements. Type the exact address of the site you want to allow and then click Allow.
> +permissions-exceptions-autoplay-media-desc = You can specify which websites are always or never allowed to autoplay media with sound. Type the address of the site you want to manage and then click Block or Allow.

Need a new ID. I guess permissions-exceptions-autoplay-media-desc would work here.

::: browser/locales/en-US/browser/preferences/preferences.ftl:857
(Diff revision 1)
>  
>  autoplay-option-ask =
>      .label = Always Ask
>  autoplay-option-allow =
>      .label = Allow Autoplay
>  autoplay-option-block =

Need a new ID: autoplay-option-dont seems to work

::: browser/locales/en-US/chrome/browser/browser.properties:962
(Diff revision 1)
>  midi.shareSysexWithFile.message = Will you allow this local file to access your MIDI devices and send/receive SysEx messages?
>  # LOCALIZATION NOTE (midi.shareSysexWithSite.message): %S is the name of the site URL (https://...) requesting MIDI access
>  midi.shareSysexWithSite.message = Will you allow %S to access your MIDI devices and send/receive SysEx messages?
>  
> -autoplay.Allow.label = Allow Autoplay
> +autoplay.Allow.label = Allow
>  autoplay.Allow.accesskey = A

Both label and accesskey need a new ID, e.g. autoplay.Allow2.label and autoplay.Allow2.accesskey

Comment 12

[Francesco Lodolo [:flod]]

Comment on attachment 8994162 [details]
Bug 1476889 - Update autoplay copy.

https://reviewboard.mozilla.org/r/258774/#review265658

Comment 13

[Francesco Lodolo [:flod]]

(In reply to Francesco Lodolo [:flod] from comment #11)
> ::: browser/locales/en-US/browser/preferences/permissions.ftl:104
> (Diff revision 1)
> >  ## Exceptions - Autoplay Media
> >  
> >  permissions-exceptions-autoplay-media-window =
> >      .title = Allowed Websites - Autoplay
> >      .style = { permissions-window.style }
> > -permissions-exceptions-autoplay-media-desc = You can specify which websites are allowed to automatically play media elements. Type the exact address of the site you want to allow and then click Allow.
> > +permissions-exceptions-autoplay-media-desc = You can specify which websites are always or never allowed to autoplay media with sound. Type the address of the site you want to manage and then click Block or Allow.
> 
> Need a new ID. I guess permissions-exceptions-autoplay-media-desc would work
> here.

I have no clue what's going on with comments on mozreview these days. I meant "permissions-exceptions-autoplay-media-desc2" here, tried to comment on mozreview, and it didn't publish.

Comment 14

[Dale Harvey (:daleharvey)]

Comment on attachment 8994162 [details]
Bug 1476889 - Update autoplay copy.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/258774/diff/1-2/

Comment 15

[Dale Harvey (:daleharvey)]

Ah apologies, I assumed (optimistically) that we only needed new id's after a release, updated

Comment 16

[Francesco Lodolo [:flod]]

Comment on attachment 8994162 [details]
Bug 1476889 - Update autoplay copy.

https://reviewboard.mozilla.org/r/258774/#review265782

Thanks, looks good.

A change of ID is needed as soon as the string lands in mozilla-central, since we moved all language to Nightly for localization.

Comment 17

[Dale Harvey (:daleharvey)]

Bryant is on PTO, so going to say this is ok

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a6b572004dcb
Update autoplay copy. r=flod

Comment 19

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/a6b572004dcb

Comment 20

[Gyula Palko[:gpalko]]

Verified as fixed on Nightly 63.0a1(20180816220128).