1476906 - Remove ReplaceHeadContentsWithHTML() from nsIHTMLEditor

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

There is no users of ReplaceHeadContentsWithHTML() outside of editor. So, we can make this method just a non-virtual method.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e38acf9613d599e96231d124a6e17ed503a5ffbd

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1476906 - Change nsIHTMLEditor::ReplaceHeadContentsWithHTML() to a non-virtual method of HTMLEditor

nsIHTMLEditor::ReplaceHeadContentsWithHTML() is used only by HTMLEditor
internally. So, it shouldn't be an nsIHTMLEditor's method.  This patch
changes it as a non-virtual method of HTMLEditor and rename it to
ReplaceHeadContentsWithSourceWithTransaction() for consistency with other
methods.

Review commit: https://reviewboard.mozilla.org/r/258086/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/258086/

Comment 3

[Makoto Kato [:m_kato]]

Comment on attachment 8993616 [details]
Bug 1476906 - Change nsIHTMLEditor::ReplaceHeadContentsWithHTML() to a non-virtual method of HTMLEditor

https://reviewboard.mozilla.org/r/258086/#review265628

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bd51af94b408
Change nsIHTMLEditor::ReplaceHeadContentsWithHTML() to a non-virtual method of HTMLEditor r=m_kato

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/bd51af94b408

Comment 6

[Jorg K (CEST = GMT+2)]

(In reply to Masayuki Nakano [:masayuki] (JST, +0900) from comment #0)
> There is no users of ReplaceHeadContentsWithHTML() outside of editor. So, we
> can make this method just a non-virtual method.
I've just noticed: My add-on ThunderHTMLedit was using that function :-(