1476908 - Rule view should be showed CSS keyframes from the shadow dom.

Status: VERIFIED FIXED

(DevTools :: Inspector: Rules, defect, P3)

Description

[nayinain]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:63.0) Gecko/20100101 Firefox/63.0
Build ID: 20180718220144

Steps to reproduce:

1. Open the following dataUrl.
data:text/html,<div></div><script>document.querySelector('div').attachShadow({mode: 'open'}).innerHTML ='<span>text</span><style>@keyframes blink {0% { border: rgba(255,0,0,1) 2px dashed ;} 100% { border: rgba(255,0,0,0) 2px dashed ;}} span {animation:blink .5s 0s infinite;}</style>';</script>
2. Inspect element on the blinking node.



Expected results:

Rule view should be showed the CSS keyframes.



Sorry for my bad English.

Comment 1

[Julian Descottes [:jdescottes]]

Thanks for logging! I believe this is linked to Bug 1454468. We need to use a different API to fetch stylesheets coming from shadow DOM.

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1476908 - Show keyframes for elements in shadow dom;

Review commit: https://reviewboard.mozilla.org/r/258406/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/258406/

Comment 3

[Brian Grinstead [:bgrins]]

Comment on attachment 8993719 [details]
Bug 1476908 - Show keyframes for elements in shadow dom;

https://reviewboard.mozilla.org/r/258406/#review265458

Nice

Comment 4

[Julian Descottes [:jdescottes]]

Thanks for the review! Try at https://treeherder.mozilla.org/#/jobs?repo=try&revision=6dd8c6b5b8edd5cb50d01449ad5f700e8928d92b

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3c97a4764682
Show keyframes for elements in shadow dom;r=bgrins

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/3c97a4764682

Comment 8

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

I have reproduced this issue using Firefox 63.0a1 (2018.07.19) on Windows 10 x64.
I can confirm this issue is fixed, I verified using Firefox 63.0b4 on Ubuntu 16.04 x64, Windows  10 x64 and Mac OS X 10.13.