1476945 - [FTL] Query TM with simple strings

Status: VERIFIED FIXED

(Webtools Graveyard :: Pontoon, enhancement, P2)

Description

[Eduardo Trápani]

I just started translating Common Voice and I have to manually search in the Machinery textbos in order to get the translations for language names from other projects.

It would be great if the suggestions were shown automatically.

Comment 1

[Matjaz Horvat [:mathjazz]]

That should also work as described. Could you provide a link?

Comment 2

[Eduardo Trápani]

For example, I'm about to translate "Arabic"[1] and the Machinery tab says "No translations available". If I type "Arabic" in "type to search machinery", then I get two 100% translations from memory.

In the case of "Breton"[2], it doesn't help to search "Breton", I need to search "breton" (case sensitive), but then I get the suggestion for "Breton"! (with initial uppercase). I'll leave it untranslated so that you can check it.

[1] https://pontoon.mozilla.org/eo/common-voice/messages.ftl/?string=179931
[2] https://pontoon.mozilla.org/eo/common-voice/messages.ftl/?string=179142

Comment 3

[Eduardo Trápani]

Attachment: Screenshot_2018-07-19 Common Voice · Esperanto (eo).png

Upon first visit to "Breton" string

Comment 4

[Eduardo Trápani]

Attachment: Screenshot_2018-07-19 Common Voice · Esperanto (eo)(1).png

After I search "Breton"

Comment 5

[Eduardo Trápani]

Attachment: Screenshot_2018-07-19 Common Voice · Esperanto (eo)(2).png

After I search "breton" (lowercase), with suggestion (uppercase)

Comment 6

[Eduardo Trápani]

Is there another way to get the already translated strings from another project while the suggestion machinery is being fixed? From Firefox to Common Voice. I tried exporting, to do the suggestions off-line and then upload the file, but they are ftl files and I don't have tools for them.

Comment 7

[Matjaz Horvat [:mathjazz]]

Thanks for the detailed bug report, Eduardo! I'm taking this bug.

Here's what's happening:

For FTL strings, we query TM with the entire source of the string (e.g. "ar = Arabic" instead of "Arabic"), because we also store FTL strings in TM as source values. Since the vast majority of string in TM are non-FTL, we should change that and send query as a simple string.

As a consequence, we'll miss (short) FTL strings, but that's only until bug 1453341 is fixed, where we'll convert FTL strings in the TM to only include simple strings.

Changing the summary to reflect that.

Comment 8

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/1027

Comment 9

[[github robot]]

Commit pushed to master at https://github.com/mozilla/pontoon

https://github.com/mozilla/pontoon/commit/b369b67b97275536236c647ac0f8778f7cc2f9f8
Fix bug 1476945: [FTL] Query TM with simple strings (#1027)

Comment 10

[Eduardo Trápani]

When will the fix be available in Pontoon? Even though the bug appears as fixed, I don't see any change yet ...

Comment 11

[Matjaz Horvat [:mathjazz]]

It should be up now.

Comment 12

[Eduardo Trápani]

It is :) Thanks Matjaž!