1476980 - Add WIX variables to MozillaBuild to support addition of MSI installer

Status: RESOLVED WONTFIX

(Firefox Build System :: MozillaBuild, task)

Description

[Kim Moir [:kmoir] ET]

Note: Per https://bugzilla.mozilla.org/show_bug.cgi?id=1475510#c2 we'll be using  WIX variables for details such as the language, version, platform, package/upgrade codes, and installer file, to make it easier for the build system to be able to fill in that kind of information (which has to be done during build time)

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Is this mainly the bug for adding WiX to MozillaBuild (and setting appropriate paths), or is there more to do besides that?

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Here's a test build that does that anyway. The little bit of local testing I did suggests it works as expected. Note that WiX depends on .NET Framework 4.5, which we're obviously not going to be bundling with this also.

https://drive.google.com/open?id=1BxMcgyS6y_7wneUcgplZpjPcmNu5RnLT
SHA256: C0B96E73D45081CB975F2B38853F444976723098A6E7FA2D1BA5FFF2333AD046

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Matt, can you try the above build out and see how it works for you?

Comment 4

[Molly Howell (she/her) (mostly inactive)]

Yep, with that build the WIX commands that I use worked fine out of the box without me needing to customize anything, so I'd say it's working. Thanks!

Comment 5

[Kim Moir [:kmoir] ET]

Is this in a current version of Mozilla build?  From looking at https://hg.mozilla.org/mozilla-build/ it doesn't seem like the wix binaries are there.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

It is not. I was planning to do a new release in early September after the Gecko 64 version bump.

Comment 7

[Kim Moir [:kmoir] ET]

Looks like the Gecko version bump has happened!

Comment 8

[Ryan VanderMeulen [:RyanVM]]

This is blocked on bug 1482435 at the moment (mainly ensuring that |mach lint| can properly detect the bootstrapped copy of node, which it currently doesn't). I discussed it with dmose yesterday and hope to see it move soon.

Is getting an official release out there with WiX included blocking something at the moment?

Comment 9

[Kim Moir [:kmoir] ET]

Yes, I need it for bug 1476983.  Is dmose actively working on bug 1482435 or does he need someone from the build team to look at it?

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Now that bug 1482435 is resolved, I'll work on moving forward with this next week. I'm at a work week this week.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Talking to Kim, it doesn't sound like we need this in MozillaBuild after all. It'll be hooked into ./mach bootstrap like Node.