1476988 - Add 'redirectID' attribute (or a set function) on nsIChildChannel and implement where necessary

Status: RESOLVED DUPLICATE of bug 1476996

(Core :: Networking: HTTP, enhancement, P3)

Description

[Honza Bambas (:mayhemer)]

The value is a redirect registrar ID generated on the parent process, pointing to an existing and waiting channel.  When set on a child channel, it instructs it to behave as it would be a redirect-target channel.  This will likely simply be a call to ConnectParent(ID) on itself from inside AsyncOpen() instead of trying to open a brand new channel.

In case of HttpChannelChild I think we want to branch somewhere at around [1], other implementations may be similar (and likely simpler :))

Note that CompleteRedirectSetup method will not be called on the new process channel.

It would be nice to also prevent calling it on the old process channel (i.e. do the decision to redirect even sooner than at [2].) but that is only a nice-to-have thing.

There is a code for interception in HttpChannelChild that is touching the redirect code, consult :jdm about that, not sure we need to take care about it.

[1] https://searchfox.org/mozilla-central/rev/6f86cc3479f80ace97f62634e2c82a483d1ede40/netwerk/protocol/http/HttpChannelChild.cpp#2703
[2] https://searchfox.org/mozilla-central/rev/6f86cc3479f80ace97f62634e2c82a483d1ede40/netwerk/protocol/http/HttpChannelParentListener.cpp#68

Comment 1

[Valentin Gosu [:valentin] (he/him)]

Implemented in bug 1476996