Closed Bug 1476991 Opened Last year Closed Last year

[RTL] Selected tab indicator in the All Tabs panel should be located at the right side of the list

Categories

(Firefox :: Tabbed Browser, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 63
Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- unaffected
firefox61 --- unaffected
firefox62 --- verified
firefox63 --- verified

People

(Reporter: itiel_yn8, Assigned: mstriemer)

References

Details

(Keywords: regression, rtl)

Attachments

(3 files)

Attached image Screenshot
Following bug 1470947, on RTL locales the selected tab indicator (see attached) should be on the right side of the site's thumbnail.
Priority: -- → P1
Assignee: nobody → mstriemer
Comment on attachment 8996461 [details]
Bug 1476991 - Move selected tab indicator to right side in RTL

https://reviewboard.mozilla.org/r/260536/#review268232
Attachment #8996461 - Flags: review?(dao+bmo) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/947673e32010
Move selected tab indicator to right side in RTL r=dao
https://hg.mozilla.org/mozilla-central/rev/947673e32010
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Looking good on latest Nightly.

I think this should be uplifted to beta alongside 1470947?
Status: RESOLVED → VERIFIED
Comment on attachment 8996461 [details]
Bug 1476991 - Move selected tab indicator to right side in RTL

Approval Request Comment
[Feature/Bug causing the regression]: bug 1470947
[User impact if declined]: Visual indicator is on the wrong side in RTL languages
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: No
[Why is the change risky/not risky?]: Just an RTL version of LTR CSS selector
[String changes made/needed]: No
Attachment #8996461 - Flags: approval-mozilla-beta?
Comment on attachment 8996461 [details]
Bug 1476991 - Move selected tab indicator to right side in RTL

CSS fix, new regression, let's uplift for beta 16.
Attachment #8996461 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attached image Bug1476991.gif
This issue is verified as fixed on Firefox 62.0b16(20180809104529) under Win 7 64-bit and Mac OS X 10.13.3.

Please see the attached video.
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.