Closed Bug 1477199 Opened 7 years ago Closed 7 years ago

Tabs are not highlighted when they are active in all tabs menu

Categories

(Firefox :: Tabbed Browser, defect)

63 Branch
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 63
Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- unaffected
firefox61 --- unaffected
firefox62 --- verified
firefox63 --- verified

People

(Reporter: cbadescu, Assigned: mstriemer)

References

Details

(Keywords: regression)

Attachments

(4 files)

Attached image Regression.gif
[Affected versions]: - Firefox 63.0a1 (20180719100142) [Affected platforms]: - Win 7 64-bit - Mac OS X 10.13.3 [Steps to reproduce]: 1.Install https://addons.mozilla.org/en-US/firefox/addon/hide-tab/ 2.Hide some tabs. 3.Click on the “v” button. 4.Use the keyboard arrows to navigate in all tabs menu. 5.Observe the tabs while you navigate. [Expected results]: - The tabs are highlighted when they are active. [Actual results]: - The tabs are not highlighted when they are active. Please see the attached video. I did a regression window and observed that Bug 1470947 is the one that caused this regression. Last good revision: e2bfc4560e97dc9b65e73ef332c01deea7208622 First bad revision: 2b968133583f63b6ea85a8b86e033016820d5a4b Pushlog:https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e2bfc4560e97dc9b65e73ef332c01deea7208622&tochange=2b968133583f63b6ea85a8b86e033016820d5a4b
Depends on: 1477594
No longer depends on: 1477594
Comment on attachment 8994347 [details] Bug 1477199 - Show keyboard highlights in all tabs menu after bad rebase https://reviewboard.mozilla.org/r/258934/#review266036
Attachment #8994347 - Flags: review?(dao+bmo) → review+
Assignee: nobody → mstriemer
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/01ccc130e68b Show keyboard highlights in all tabs menu after bad rebase r=dao
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Attached image Bug1477199.gif
This issue is verified as fixed on Firefox 63.0a1 (20180729220222) under Win 7 64-bit and Mac OS X 10.13.3. Please see the attached video.
Status: RESOLVED → VERIFIED
Comment on attachment 8994347 [details] Bug 1477199 - Show keyboard highlights in all tabs menu after bad rebase Approval Request Comment [Feature/Bug causing the regression]: bug 1470947 [User impact if declined]: Keyboard navigation is not visually shown in all tabs menu [Is this code covered by automated tests?]: No [Has the fix been verified in Nightly?]: Yes [Needs manual test from QE? If yes, steps to reproduce]: [List of other uplifts needed for the feature/fix]: [Is the change risky?]: No [Why is the change risky/not risky?]: Removes a CSS selector added by a bad rebase [String changes made/needed]: No
Attachment #8994347 - Flags: approval-mozilla-beta?
Comment on attachment 8994347 [details] Bug 1477199 - Show keyboard highlights in all tabs menu after bad rebase CSS fix for menu highlighting. OK to uplift for beta 16.
Attachment #8994347 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attached image Bug1477199.gif
This issue is verified as fixed on Firefox 62.0b16(20180809104529) under Win 7 64-bit and Mac OS X 10.13.3. Please see the attached video.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: