1477199 - Tabs are not highlighted when they are active in all tabs menu

Status: VERIFIED FIXED

Description

[CosminB]

Attachment: Regression.gif

[Affected versions]:
- Firefox 63.0a1 (20180719100142)

[Affected platforms]:
- Win 7 64-bit
- Mac OS X 10.13.3

[Steps to reproduce]:
1.Install https://addons.mozilla.org/en-US/firefox/addon/hide-tab/ 
2.Hide some tabs.
3.Click on the “v” button.
4.Use the keyboard arrows to navigate in all tabs menu.
5.Observe the tabs while you navigate.

[Expected results]:
- The tabs are highlighted when they are active.

[Actual results]:
- The tabs are not highlighted when they are active.

Please see the attached video.

I did a regression window and observed that Bug 1470947 is the one that caused this regression.

Last good revision: e2bfc4560e97dc9b65e73ef332c01deea7208622
First bad revision: 2b968133583f63b6ea85a8b86e033016820d5a4b
Pushlog:https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e2bfc4560e97dc9b65e73ef332c01deea7208622&tochange=2b968133583f63b6ea85a8b86e033016820d5a4b

Comment 1

[Mark Striemer [:mstriemer]]

Attachment: Bug 1477199 - Show keyboard highlights in all tabs menu after bad rebase

Review commit: https://reviewboard.mozilla.org/r/258934/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/258934/

Comment 2

[Mark Striemer [:mstriemer]]

The moved CSS selector got added back while rebasing https://hg.mozilla.org/mozilla-central/diff/618784ce43c7/browser/themes/shared/tabs.inc.css.

Comment 3

[Dão Gottwald [::dao]]

Comment on attachment 8994347 [details]
Bug 1477199 - Show keyboard highlights in all tabs menu after bad rebase

https://reviewboard.mozilla.org/r/258934/#review266036

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/01ccc130e68b
Show keyboard highlights in all tabs menu after bad rebase r=dao

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/01ccc130e68b

Comment 6

[CosminB]

Attachment: Bug1477199.gif

This issue is verified as fixed on Firefox 63.0a1 (20180729220222) under Win 7 64-bit and Mac OS X 10.13.3.

Please see the attached video.

Comment 7

[Mark Striemer [:mstriemer]]

Comment on attachment 8994347 [details]
Bug 1477199 - Show keyboard highlights in all tabs menu after bad rebase

Approval Request Comment
[Feature/Bug causing the regression]: bug 1470947
[User impact if declined]: Keyboard navigation is not visually shown in all tabs menu
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]:
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: No
[Why is the change risky/not risky?]: Removes a CSS selector added by a bad rebase
[String changes made/needed]: No

Comment 8

[Liz Henry (:lizzard) (use needinfo)]

Comment on attachment 8994347 [details]
Bug 1477199 - Show keyboard highlights in all tabs menu after bad rebase

CSS fix for menu highlighting. OK to uplift for beta 16.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/32b73599ce15

Comment 10

[CosminB]

Attachment: Bug1477199.gif

This issue is verified as fixed on Firefox 62.0b16(20180809104529) under Win 7 64-bit and Mac OS X 10.13.3.

Please see the attached video.