1477201 - PerTestCoverageUtils.jsm is not available in stable Marionette versions, which makes upstream wpt fail

Status: RESOLVED FIXED

(Testing :: web-platform-tests, defect)

Comment 1

[Marco Castelluccio [:marco]]

Attachment: Patch

Comment 2

[Marco Castelluccio [:marco]]

This unfortunately duplicates the check in PerTestCoverageUtils.jsm, but I think it's acceptable.

Comment 3

[Marco Castelluccio [:marco]]

Attachment: Patch - Option 2

This is an alternative version, using mozinfo['ccov'] to detect if we are in a coverage build.

Comment 4

[James Graham [:jgraham]]

Comment on attachment 8993620 [details] [diff] [review]
Patch - Option 2

Review of attachment 8993620 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Would it be possible to either land this with the bug number of the original bug, or apply it separately to the GitHub branch to unstick travis? Alternatively I can do the latter if you prefer.

::: testing/web-platform/tests/tools/wptrunner/wptrunner/browsers/firefox.py
@@ +80,5 @@
>                                                           run_info_data,
>                                                           **kwargs),
>              "leak_check": kwargs["leak_check"],
>              "asan": run_info_data.get("asan"),
> +            "ccov": run_info_data.get("ccov"),

I don't think this change is needed.

Comment 5

[Marco Castelluccio [:marco]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/44b123467fc3