Closed
Bug 1477202
Opened 6 years ago
Closed 6 years ago
Don't ship PerTestCoverageUtils.jsm to users
Categories
(Testing :: Code Coverage, enhancement)
Testing
Code Coverage
Tracking
(firefox63 fixed)
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: marco, Assigned: marco)
References
Details
Attachments
(1 file)
3.52 KB,
patch
|
florian
:
review+
|
Details | Diff | Splinter Review |
Because of bug 1344267, we'd ship PerTestCoverageUtils.jsm to users, but we don't need to.
Assignee | ||
Updated•6 years ago
|
Summary: Don't ship PerTestCoverageUtils.jsm in → Don't ship PerTestCoverageUtils.jsm to users
Assignee | ||
Comment 1•6 years ago
|
||
Attachment #8993617 -
Flags: review?(florian)
Comment 2•6 years ago
|
||
Comment on attachment 8993617 [details] [diff] [review]
Patch
Review of attachment 8993617 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good to me, assuming you have verified that the MOZ_CODE_COVERAGE ifdefs work and that you don't need to add anything in 'DEFINES' in moz.build.
Attachment #8993617 -
Flags: review?(florian) → review+
Pushed by mcastelluccio@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/75aa72e75bee
Avoid shipping PerTestCoverageUtils.jsm to users by only adding it to Marionette when MOZ_CODE_COVERAGE is defined. r=florian
Comment 4•6 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•