Closed Bug 1477350 Opened Last year Closed Last year

Blocked autoplay icon does not use light colors in dark themes

Categories

(Firefox :: Site Identity and Permission Panels, defect, P2)

defect

Tracking

()

RESOLVED FIXED
Firefox 63
Tracking Status
firefox62 --- disabled
firefox63 --- fixed

People

(Reporter: jaws, Assigned: daleharvey)

References

Details

Attachments

(3 files)

Attached image Screenshot of bug
See attached screenshot. The icon should be using the white/light-gray color that the other identity icons are using.
Also in the popup.
Huh, I thought I had checked this stuff in my review, must have missed that one.

In any case, Dale, would you like to take this?
Flags: needinfo?(dharvey)
Priority: -- → P2
Yuo also thought I had checked context-fill values, will take
Assignee: nobody → dharvey
Flags: needinfo?(dharvey)
Bryant, if I take out the fill= and stroke= from https://dxr.mozilla.org/mozilla-central/source/browser/themes/shared/notification-icons/autoplay-media-blocked.svg and give it context-stroke= it still ends up looking wrong this is the only icon using stroke in the url bar so I think it should probably be reworked to use fill only

https://i.imgur.com/QM3jE7D.png
Flags: needinfo?(bmao)
Hi Dale, can you try if this one works? -> https://send.firefox.com/download/d38e95539a/#EBhzpH3RR1WHgirbUf1y1A
Thanks!
Flags: needinfo?(bmao) → needinfo?(dharvey)
Yup thats great, now I can see that the original was also broken on the default theme as well, will fix, cheers
Flags: needinfo?(dharvey)
Comment on attachment 8994434 [details]
Bug 1477350 - Fix autoplay blocked icon to use context-fill correctly.

https://reviewboard.mozilla.org/r/258988/#review265990

::: browser/themes/shared/notification-icons/autoplay-media-blocked.svg:4
(Diff revision 1)
>  <!-- This Source Code Form is subject to the terms of the Mozilla Public
>     - License, v. 2.0. If a copy of the MPL was not distributed with this
>     - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
>  <svg xmlns="http://www.w3.org/2000/svg" width="16" height="16" viewBox="0 0 16 16" fill="context-fill" fill-opacity="context-fill-opacity">

I've optimized it further: https://gist.github.com/nt1m/29f0e5b592db114a6fd4f394910d6015
Nice thanks, updated the PR with yours
Comment on attachment 8994434 [details]
Bug 1477350 - Fix autoplay blocked icon to use context-fill correctly.

https://reviewboard.mozilla.org/r/258988/#review266134
Attachment #8994434 - Flags: review?(florian) → review+
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/caf5ba52d57e
Fix autoplay blocked icon to use context-fill correctly. r=florian
https://hg.mozilla.org/mozilla-central/rev/caf5ba52d57e
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
I have reproduced this bug with Nightly 63.0a1 (2018-07-20) on Windows 10, 64 Bit!
This bug's fix is verified with latest Nightly!

Build ID 	20180825100331
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:63.0) Gecko/20100101 Firefox/63.0
QA Whiteboard: [bugday-20180822]
QA Whiteboard: [bugday-20180822] → [bugday-20180822] [good first verify]
You need to log in before you can comment on or make changes to this bug.