Closed
Bug 1477381
Opened 6 years ago
Closed 6 years ago
JS::ubi::TracerConcrete<T>::edges should be a public method
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: KrisWright, Assigned: KrisWright)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
902 bytes,
patch
|
erahm
:
review+
|
Details | Diff | Splinter Review |
JS::ubi::Base::edges (https://searchfox.org/mozilla-central/rev/8384a6519437f5eefbe522196f9ddf5c8b1d3fb4/js/public/UbiNode.h#593) is a public method, but when TracerConcrete inherits from Base it is overridden with a private method. In order for TracerConcrete subclasses (such as in reporting the tracer edges from DOM reflector JSObjects) to call the superclass method it should stay public.
|
Assignee | |
Comment 1•6 years ago
|
||
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → kwright
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•6 years ago
|
Attachment #8993780 -
Flags: review?(nfitzgerald)
|
|
Assignee | |
Updated•6 years ago
|
Attachment #8993780 -
Flags: review?(nfitzgerald) → review?(erahm)
|
||
Updated•6 years ago
|
Attachment #8993780 -
Flags: review?(erahm) → review+
|
|
Assignee | |
Updated•6 years ago
|
Keywords: checkin-needed
|
|
||
Comment 2•6 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/f4c0996b0c34b6561201eb28f6ffa0742a692ef6 Bug 1477381 - JS::ubi::TracerConcrete<Referent>::edges as a public method. r=erahm
|
||
Updated•6 years ago
|
Keywords: checkin-needed
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/f4c0996b0c34
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•