1477382 - Dark Theme: list of minor changes

Status: RESOLVED FIXED

(Firefox for iOS :: Theme & Visual Design, defect, P2)

Description

[:garvan]

Rather than a bunch of bugs for these minor theme issues, I will fix them as part of a single PR:

- Top navigation bar settings not theming
- Favicons need a white background, most noticeable on the home panel
- dynamic text on settings not growing (seems to be related to theme changes)
- search tabs bar (and the status bar is grey not ink)
- invert pills on search suggestion
- remote tabs panel device icon tint (currently black and icons are invisible) 
- downloads panel header text

Comment 1

[:garvan]

Updated TODO list:
- Top navigation bar settings not theming
- dynamic text on settings not growing (seems to be related to theme changes)
- invert pills on search suggestion
- remote tabs panel device icon tint (currently black and icons are invisible) 
- downloads panel header text

Already fixed in other bugs:
- Favicons need a white background, most noticeable on the home panel
- search tabs bar (and the status bar is grey not ink)

Comment 2

[:garvan]

Also going to fix top tabs theme not updating when theme changed.

Comment 3

[:garvan]

Moved the dynamic text bug to its own bug https://bugzilla.mozilla.org/show_bug.cgi?id=1479556

Comment 4

[:garvan]

Attachment: Pull request

Comment 5

[:garvan]

landed on master

Comment 6

[:garvan]

Comment on attachment 8996053 [details] [review]
Pull request

farhan r+'d on github