147741 - hook up document level notifications for nsIContentPolicy

Status: VERIFIED FIXED

(Core Graveyard :: Embedding: APIs, defect)

Description

[rpotts (gone)]

Currently, the nsIContentPolicy interface is only called for image/plugin/script
loads.

It also needs to receive notifications for frame/top-level document loads too.

In order to achieve this, the following must be done:
 1. hook up nsIContentPolicy::SUBDOCUMENT notifications.
 2. introduce a new nsIContentPolicy::DOCUMENT notification
 3. hook it up to fire for each 'top level document' load...

Alternatively, both frame and top level document notifications could be
represented by DOCUMENT notifications...

i'm open to either approach...

-- rick

Comment 1

[Warren Harris]

test

Comment 2

[rpotts (gone)]

Attachment: consult the nsIContentPolicy for document and sub-document loads.

Comment 3

[rpotts (gone)]

The above patch causes document and sub-document URIs to pass through the
nsIContentPolicy listeners.

This allows frame loads to be blocked via the nsIDocShell::allowSubframes attribute.

-- rick

Comment 4

[Darin Fisher]

Comment on attachment 88596 [details] [diff] [review]
consult the nsIContentPolicy for document and sub-document loads.

sr=darin

Comment 5

[Johnny Stenback (:jst)]

Comment on attachment 88596 [details] [diff] [review]
consult the nsIContentPolicy for document and sub-document loads.

r=jst

Comment 6

[rpotts (gone)]

The patch has been checked into the trunk.

Comment 7

[rpotts (gone)]

marking fixed... and adding keywords so it will be considered for the branch.

-- rick

Comment 8

[Chak Nanga]

Marking topembed+

Comment 9

[scottputterman]

mdunn, would you be able to verify this on the trunk today?

Comment 10

[Jaime Rodriguez, Jr.]

mdunn - is this something you can verify on the trunk? if yes, pls do so, then
mark this as verified, so that we can take it on the branch asap. thanks!

Comment 11

[Judson Valeski]

please checkin to the 1.0.1 branch. once there, remove the "mozilla1.0.1+"
keyword and add the "fixed1.0.1" keyword.

Comment 12

[Judson Valeski]

I can verify this on the trunk; doing so.

Comment 13

[rpotts (gone)]

checked into the branch too !

Comment 14

[Jaime Rodriguez, Jr.]

posthumus adt1.0.1+. pls get an adt1.0.1+ before checking into the 1.0 branch.
thanks!