Closed Bug 147741 Opened 23 years ago Closed 23 years ago

hook up document level notifications for nsIContentPolicy

Categories

(Core Graveyard :: Embedding: APIs, defect)

Product:
Core Graveyard
Component:
Embedding: APIs
Platform:
x86
Windows 2000
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla1.0.1

People

(Reporter: rpotts, Assigned: rpotts)

References

Details

(Keywords: topembed+, Whiteboard: [adt2 RTM] [ETA 06/27])

Attachments

(1 file)

consult the nsIContentPolicy for document and sub-document loads.
2.21 KB, patch
jst
: review+
darin.moz
: superreview+
jud
: approval+
Details | Diff | Splinter Review
Currently, the nsIContentPolicy interface is only called for image/plugin/script loads. It also needs to receive notifications for frame/top-level document loads too. In order to achieve this, the following must be done: 1. hook up nsIContentPolicy::SUBDOCUMENT notifications. 2. introduce a new nsIContentPolicy::DOCUMENT notification 3. hook it up to fire for each 'top level document' load... Alternatively, both frame and top level document notifications could be represented by DOCUMENT notifications... i'm open to either approach... -- rick
test
Blocks: 153246
The above patch causes document and sub-document URIs to pass through the nsIContentPolicy listeners. This allows frame loads to be blocked via the nsIDocShell::allowSubframes attribute. -- rick
Comment on attachment 88596 [details] [diff] [review] consult the nsIContentPolicy for document and sub-document loads. sr=darin
Attachment #88596 - Flags: superreview+
Comment on attachment 88596 [details] [diff] [review] consult the nsIContentPolicy for document and sub-document loads. r=jst
Attachment #88596 - Flags: review+
The patch has been checked into the trunk.
marking fixed... and adding keywords so it will be considered for the branch. -- rick
Status: NEW → RESOLVED
Closed: 23 years ago
Keywords: adt1.0.1, topembed
Resolution: --- → FIXED
Marking topembed+
Keywords: topembed → topembed+
Keywords: approval, mozilla1.0.1, nsbeta1
Whiteboard: [adt2 RTM] [ETA 06/24]
Target Milestone: --- → mozilla1.0.1
mdunn, would you be able to verify this on the trunk today?
mdunn - is this something you can verify on the trunk? if yes, pls do so, then mark this as verified, so that we can take it on the branch asap. thanks!
Blocks: 143047
Attachment #88596 - Flags: approval+
please checkin to the 1.0.1 branch. once there, remove the "mozilla1.0.1+" keyword and add the "fixed1.0.1" keyword.
Keywords: mozilla1.0.1 → mozilla1.0.1+
I can verify this on the trunk; doing so.
Status: RESOLVED → VERIFIED
checked into the branch too !
Keywords: mozilla1.0.1+ → fixed1.0.1
posthumus adt1.0.1+. pls get an adt1.0.1+ before checking into the 1.0 branch. thanks!
Keywords: adt1.0.1 → adt1.0.1+
Whiteboard: [adt2 RTM] [ETA 06/24] → [adt2 RTM] [ETA 06/27]
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: