Closed
Bug 1477476
Opened 6 years ago
Closed 6 years ago
Drop check for malformed sessionId from Marionette
Categories
(Testing :: geckodriver, enhancement)
Testing
geckodriver
Tracking
(firefox63 fixed)
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: ato, Assigned: ato)
Details
Attachments
(1 file)
1.95 KB,
patch
|
automatedtester
:
review+
whimboo
:
review+
|
Details | Diff | Splinter Review |
geckodriver checks if the sessionId field returned from Marionette
starts with "{" and ends with "}", which it hasn’t done for quite
some time:
> if session_id.starts_with("{") && session_id.ends_with("}") {
> session_id = &session_id[1..session_id.len()-1];
> }
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → ato
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•6 years ago
|
||
Marionette used to return a session UUID starting with "{" and ending with "}" from the uuid-generator in Gecko. It has not done this for a very long time rendering this geckodriver check needless.
Assignee | ||
Updated•6 years ago
|
Attachment #8993907 -
Flags: review?(dburns)
Assignee | ||
Comment 2•6 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b07d67b158a9b071f73f00bc49d47bda22429f31
Updated•6 years ago
|
Attachment #8993907 -
Flags: review+
Updated•6 years ago
|
Attachment #8993907 -
Flags: review?(dburns) → review+
Pushed by atolfsen@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/666d7dc7a32c Drop geckodriver check for malformed sessionId from Marionette. r=automatedtester
Comment 4•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/666d7dc7a32c
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•