1477519 - qimportbz not compatible with Mercurial 4.6.2.

Status: RESOLVED FIXED

(Developer Services :: Mercurial: qimportbz, defect)

Description

[Jorg K (CEST = GMT+2)]

Setting up I new Windows machine I installed MozillaBuild 3.2 which gave me Mercurial 4.5.3.

I did a |mach bootstrap| and got Mercurial 4.6.2.

hg qimport bz:1477401 doesn't work in that combination, I get a python call stack.

Reinstalling MozillaBuild 3.2 and thus reverting the Mercurial update fixed the problem.

Comment 1

[Connor Sheehan [:sheehan]]

Hey Jorg, can you please attach the Python call stack you see when you use the extension? :)

Comment 2

[Connor Sheehan [:sheehan]]

Attachment: qimportbz: fix test under Mercurial 4.6.2 (Bug 1477519) r?gps

This test has been broken for some time. It turns out bzexport changes
the patch name under the hood and this was not reflected in the test.
As a result, the default patch name already existed and the test
would enter an endless loop asking to rename the patch.

Comment 3

[Connor Sheehan [:sheehan]]

Attachment: qimportbz: Make compatible with modern Mercurial versions (Bug 1477519) r?gps

Under Mercurial 4.6.2, `patch.extract` is now a context manager.
Callers no longer need to unlink or remove the file, as it is
tied to the lifetime of the context manager. This commit makes
qimportbz use the context manager when running Mercurial 4.6.2.

We also register config options, to avoid devel-warnings in tests.

Comment 4

[Jorg K (CEST = GMT+2)]

Attachment: 1477519.txt - log of python callback

I didn't attach the log in the first place since I thought you'd try it yourself. Apparently that has happened already, so I'm not sure that you still need it. Here it is anyway.

Thanks for the quick action!

Comment 5

[Phabricator Automation]

Comment on attachment 8994259 [details]
qimportbz: fix test under Mercurial 4.6.2 (Bug 1477519) r?gps

Gregory Szorc [:gps] has approved the revision.

https://phabricator.services.mozilla.com/D2298

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/ba1e43d1ba0e
qimportbz: fix test under Mercurial 4.6.2 r=gps

Comment 7

[Phabricator Automation]

Comment on attachment 8994260 [details]
qimportbz: Make compatible with modern Mercurial versions (Bug 1477519) r?gps

Gregory Szorc [:gps] has approved the revision.

https://phabricator.services.mozilla.com/D2299

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/c5de3f3f317d
qimportbz: Make compatible with modern Mercurial versions r=gps

Comment 9

[Connor Sheehan [:sheehan]]

Thanks, Jorg. I just wanted to ensure that the test failure I observed was the same error you were seeing in the wild. :)

I am closing this bug as resolved, since tests are passing and the stack trace in the attachment should no longer appear.

Please re-open the bug if any other problems arise!