1477524 - Update quotes and counters to work trough the flattened tree

Status: RESOLVED FIXED

(Core :: Layout, enhancement, P3)

Description

[Yusuf Sermet [:yusuf]]

To accommodate shadow DOM reliably with quotes and counters (in the context of values of content property), they need to work on the flattened tree instead of the document tree (credit -> emilio). In Bug 1463600, we are updating the quote and counter implementation to use the flattened tree. As a prerequisite to that, we need to update nsLayoutUtils::CompareTreePosition to use the flattened tree as well, which currently uses the regular tree. Not to reiterate things that are already greatly explained:

More info on why: https://github.com/w3c/csswg-drafts/issues/2679

More info on how: https://bugzilla.mozilla.org/show_bug.cgi?id=1463600#c31

Comment 1

[Martin Robinson (email:[e-mail])]

Attachment: Bug 1477524 - Update quotes and counters to work trough the flattened tree r=emilio

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ce66cc2cbb95
Update quotes and counters to work trough the flattened tree r=emilio

Comment 3

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/34215 for changes under testing/web-platform/tests

Comment 4

[Norisz Fay [:noriszfay]]

Backed out for causing build bustages on nsCounterManager.cpp

Backout link

Push with failures

Failure log

Comment 5

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e0e15fc6dbf0
Update quotes and counters to work trough the flattened tree r=emilio

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/e0e15fc6dbf0

Comment 8

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by mrobinson

Comment 9

[Martin Robinson (email:[e-mail])]

I have merged a new version of this change which fixes the build issue.