Hide display: -moz-box and display: -moz-inline-box from content in Nightly / early beta.

RESOLVED FIXED in Firefox 63

Status

()

RESOLVED FIXED
8 months ago
3 months ago

People

(Reporter: emilio, Assigned: emilio)

Tracking

({dev-doc-complete, site-compat})

unspecified
mozilla63
dev-doc-complete, site-compat
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 months ago
Use counters are relatively high[1], and since we can't collect URLs to see where it's used and whether it's broken or not with or without them, I propose to hide them on nightly and early beta, to collect potential breakage.

[1]: https://georgf.github.io/usecounters/index.html#kind=page&group=DEPRECATED&channel=beta&version=62
Comment on attachment 8994018 [details]
Bug 1477553: Hide display: -moz-box|-moz-inline-box from content on Nightly and early beta. r?xidorn

Xidorn Quan [:xidorn] UTC+10 has approved the revision.

https://phabricator.services.mozilla.com/D2288
Attachment #8994018 - Flags: review+
Keywords: site-compat
Keywords: dev-doc-needed

Comment 3

8 months ago
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d0cb9041aa08
Hide display: -moz-box|-moz-inline-box from content on Nightly and early beta. r=xidorn
Backed out for browser chrome mochitest failures on /browser_parsable_css.js

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&filter-searchStr=Linux%20x64%20opt%20Mochitests%20with%20e10s%20test-linux64%2Fopt-mochitest-browser-chrome-e10s-6%20M-e10s(bc6)&fromchange=d0cb9041aa08de83ab41909c913c788122de509f&tochange=7b67759e227affd124ad39f5be028f1711b60107&selectedJob=189480616

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=189480616&repo=mozilla-inbound&lineNumber=2471

Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/7b67759e227affd124ad39f5be028f1711b60107

[task 2018-07-23T09:02:54.378Z] 09:02:54     INFO - Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-suppressed’.  Ruleset ignored due to bad selector." on resource://gre-resources/html.css because of whitelist item {"sourceName":"/\\b(contenteditable|EditorOverride|svg|forms|html|mathml|ua)\\.css$/i","errorMessage":"/Unknown pseudo-class.*-moz-/i","isFromDevTools":false,"used":true}
[task 2018-07-23T09:02:54.380Z] 09:02:54     INFO - Buffered messages finished
[task 2018-07-23T09:02:54.381Z] 09:02:54     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_parsable_css.js | Got error message for resource://gre-resources/html.css: Error in parsing value for ‘display’.  Declaration dropped. - 
[task 2018-07-23T09:02:54.382Z] 09:02:54     INFO - Stack trace:
[task 2018-07-23T09:02:54.383Z] 09:02:54     INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_parsable_css.js:messageIsCSSError:243
[task 2018-07-23T09:02:54.384Z] 09:02:54     INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_parsable_css.js:checkAllTheCSS:442
[task 2018-07-23T09:02:54.385Z] 09:02:54     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1103
[task 2018-07-23T09:02:54.386Z] 09:02:54     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1094
[task 2018-07-23T09:02:54.387Z] 09:02:54     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:996
[task 2018-07-23T09:02:54.388Z] 09:02:54     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795
[task 2018-07-23T09:02:54.389Z] 09:02:54     INFO - Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." on resource://gre-resources/html.css because of whitelist item {"sourceName":"/\\b(contenteditable|EditorOverride|svg|forms|html|mathml|ua)\\.css$/i","errorMessage":"/Unknown pseudo-class.*-moz-/i","isFromDevTools":false,"used":true}
[task 2018-07-23T09:02:54.391Z] 09:02:54     INFO - Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-html-canvas-content’.  Ruleset ignored due to bad selector." on resource://gre-resources/html.css because of whitelist item {"sourceName":"/\\b(contenteditable|EditorOverride|svg|forms|html|mathml|ua)\\.css$/i","errorMessage":"/Unknown pseudo-class.*-moz-/i","isFromDevTools":false,"used":true}
[task 2018-07-23T09:02:54.392Z] 09:02:54     INFO - Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." on resource://gre-resources/html.css because of whitelist item {"sourceName":"/\\b(contenteditable|EditorOverride|svg|forms|html|mathml|ua)\\.css$/i","errorMessage":"/Unknown pseudo-class.*-moz-/i","isFromDevTools":false,"used":true}
[task 2018-07-23T09:02:54.394Z] 09:02:54     INFO - Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." on resource://gre-resources/html.css because of whitelist item {"sourceName":"/\\b(contenteditable|EditorOverride|svg|forms|html|mathml|ua)\\.css$/i","errorMessage":"/Unknown pseudo-class.*-moz-/i","isFromDevTools":false,"used":true}
[task 2018-07-23T09:02:54.395Z] 09:02:54     INFO - Ignored error "Unknown property ‘-moz-min-font-size-ratio’.  Declaration dropped." on resource://gre-resources/html.css because of whitelist item {"sourceName":"/\\b(html|mathml|ua)\\.css$/i","errorMessage":"/Unknown property.*-moz-/i","isFromDevTools":false,"used":true}
[task 2018-07-23T09:02:54.397Z] 09:02:54     INFO - Ignored error "Unknown property ‘-moz-min-font-size-ratio’.  Declaration dropped." on resource://gre-resources/html.css because of whitelist item {"sourceName":"/\\b(html|mathml|ua)\\.css$/i","errorMessage":"/Unknown property.*-moz-/i","isFromDevTools":false,"used":true}
[task 2018-07-23T09:02:54.398Z] 09:02:54     INFO - Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-canvas’.  Ruleset ignored due to bad selector." on resource://gre/res/EditorOverride.css because of whitelist item {"sourceName":"/\\b(contenteditable|EditorOverride|svg|forms|html|mathml|ua)\\.css$/i","errorMessage":"/Unknown pseudo-class.*-moz-/i","isFromDevTools":false,"used":true}
[task 2018-07-23T09:02:54.399Z] 09:02:54     INFO - Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-display-comboboxcontrol-frame’.  Ruleset ignored due to bad selector." on resource://gre/res/EditorOverride.css because of whitelist item {"sourceName":"/\\b(contenteditable|EditorOverride|svg|forms|html|mathml|ua)\\.css$/i","errorMessage":"/Unknown pseudo-class.*-moz-/i","isFromDevTools":false,"used":true}
[task 2018-07-23T09:02:54.401Z] 09:02:54     INFO - Ignored error "Unknown property ‘-moz-math-display’.  Declaration dropped." on resource://gre-resources/mathml.css because of whitelist item {"sourceName":"/\\b(html|mathml|ua)\\.css$/i","errorMessage":"/Unknown property.*-moz-/i","isFromDevTools":false,"used":true}
[task 2018-07-23T09:02:54.402Z] 09:02:54     INFO - Ignored error "Unknown property ‘-moz-math-display’.  Declaration dropped." on resource://gre-resources/mathml.css because of whitelist item {"sourceName":"/\\b(html|mathml|ua)\\.css$/i","errorMessage":"/Unknown property.*-moz-/i","isFromDevTools":false,"used":true}
[task 2018-07-23T09:02:54.404Z] 09:02:54     INFO - Ignored error "Unknown property ‘-moz-math-display’.  Declaration dropped." on resource://gre-resources/mathml.css because of whitelist item {"sourceName":"/\\b(html|mathml|ua)\\.css$/i","errorMessage":"/Unknown property.*-moz-/i","isFromDevTools":false,"used":true}
[task 2018-07-23T09:02:54.406Z] 09:02:54     INFO - Ignored error "Unknown property ‘-moz-math-display’.  Declaration dropped." on resource://gre-resources/mathml.css because of whitelist item {"sourceName":"/\\b(html|mathml|ua)\\.css$/i","errorMessage":"/Unknown property.*-moz-/i","isFromDevTools":false,"used":true}
[task 2018-07-23T09:02:54.407Z] 09:02:54     INFO - Ignored error "Unknown property ‘-moz-math-display’.  Declaration dropped." on resource://gre-resources/mathml.css because of whitelist item {"sourceName":"/\\b(html|mathml|ua)\\.css$/i","errorMessage":"/Unknown property.*-moz-/i","isFromDevTools":false,"used":true}
[task 2018-07-23T09:02:54.409Z] 09:02:54     INFO - Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-mathml-anonymous-block’.  Ruleset ignored due to bad selector." on resource://gre-resources/mathml.css because of whitelist item {"sourceName":"/\\b(contenteditable|EditorOverride|svg|forms|html|mathml|ua)\\.css$/i","errorMessage":"/Unknown pseudo-class.*-moz-/i","isFromDevTools":false,"used":true}
[task 2018-07-23T09:02:54.410Z] 09:02:54     INFO - Ignored error "Unknown property ‘-moz-math-display’.  Declaration dropped." on resource://gre-resources/mathml.css because of whitelist item {"sourceName":"/\\b(html|mathml|ua)\\.css$/i","errorMessage":"/Unknown property.*-moz-/i","isFromDevTools":false,"used":true}
[task 2018-07-23T09:02:54.412Z] 09:02:54     INFO - Ignored error "Unknown property ‘-moz-math-display’.  Declaration dropped." on resource://gre-resources/mathml.css because of whitelist item {"sourceName":"/\\b(html|mathml|ua)\\.css$/i","errorMessage":"/Unknown property.*-moz-/i","isFromDevTools":false,"used":true}
[task 2018-07-23T09:02:54.413Z] 09:02:54     INFO - Ignored error "Unknown property ‘-moz-script-level’.  Declaration dropped." on resource://gre-resources/mathml.css because of whitelist item {"sourceName":"/\\b(html|mathml|ua)\\.css$/i","errorMessage":"/Unknown property.*-moz-/i","isFromDevTools":false,"used":true}
[task 2018-07-23T09:02:54.415Z] 09:02:54     INFO - Ignored error "Unknown property ‘-moz-script-level’.  Declaration dropped." on resource://gre-resources/mathml.css because of whitelist item {"sourceName":"/\\b(html|mathml|ua)\\.css$/i","errorMessage":"/Unknown property.*-moz-/i","isFromDevTools":false,"used":true}
[task 2018-07-23T09:02:54.417Z] 09:02:54     INFO - Ignored error "Unknown property ‘-moz-math-display’.  Declaration dropped." on resource://gre-resources/mathml.css because of whitelist item {"sourceName":"/\\b(html|mathml|ua)\\.css$/i","errorMessage":"/Unknown property.*-moz-/i","isFromDevTools":false,"used":true}
[task 2018-07-23T09:02:54.419Z] 09:02:54     INFO - Ignored error "Unknown property ‘-moz-script-level’.  Declaration dropped." on resource://gre-resources/mathml.css because of whitelist item {"sourceName":"/\\b(html|mathml|ua)\\.css$/i","errorMessage":"/Unknown property.*-moz-/i","isFromDevTools":false,"used":true}
[task 2018-07-23T09:02:54.420Z] 09:02:54     INFO - Ignored error "Unknown property ‘-moz-math-display’.  Declaration dropped." on resource://gre-resources/mathml.css because of whitelist item {"sourceName":"/\\b(html|mathml|ua)\\.css$/i","errorMessage":"/Unknown property.*-moz-/i","isFromDevTools":false,"used":true}
[task 2018-07-23T09:02:54.422Z] 09:02:54     INFO - Ignored error "Unknown property ‘-moz-script-level’.  Declaration dropped." on resource://gre-resources/mathml.css because of whitelist item {"sourceName":"/\\b(html|mathml|ua)\\.css$/i","errorMessage":"/Unknown property.*-moz-/i","isFromDevTools":false,"used":true}
[task 2018-07-23T09:02:54.424Z] 09:02:54     INFO - Ignored error "Unknown property ‘-moz-math-display’.  Declaration dropped." on resource://gre-resources/mathml.css because of whitelist item {"sourceName":"/\\b(html|mathml|ua)\\.css$/i","errorMessage":"/Unknown property.*-moz-/i","isFromDevTools":false,"used":true}
[task 2018-07-23T09:02:54.425Z] 09:02:54     INFO - Ignored error "Unknown property ‘-moz-math-display’.  Declaration dropped." on resource://gre-resources/mathml.css because of whitelist item {"sourceName":"/\\b(html|mathml|ua)\\.css$/i","errorMessage":"/Unknown property.*-moz-/i","isFromDevTools":false,"used":true}
[task 2018-07-23T09:02:54.427Z] 09:02:54     INFO - Ignored error "Unknown property ‘-moz-math-display’.  Declaration dropped." on resource://gre-resources/mathml.css because of whitelist item {"sourceName":"/\\b(html|mathml|ua)\\.css$/i","errorMessage":"/Unknown property.*-moz-/i","isFromDevTools":false,"used":true}
[task 2018-07-23T09:02:54.429Z] 09:02:54     INFO - Ignored error "Unknown property ‘-moz-math-display’.  Declaration dropped." on resource://gre-resources/mathml.css because of whitelist item {"sourceName":"/\\b(html|mathml|ua)\\.css$/i","errorMessage":"/Unknown property.*-moz-/i","isFromDevTools":false,"used":true}
[task 2018-07-23T09:02:54.430Z] 09:02:54     INFO - Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-canvas’.  Ruleset ignored due to bad selector." on resource://gre/res/contenteditable.css because of whitelist item {"sourceName":"/\\b(contenteditable|EditorOverride|svg|forms|html|mathml|ua)\\.css$/i","errorMessage":"/Unknown pseudo-class.*-moz-/i","isFromDevTools":false,"used":true}
[task 2018-07-23T09:02:54.432Z] 09:02:54     INFO - Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-display-comboboxcontrol-frame’.  Ruleset ignored due to bad selector." on resource://gre/res/contenteditable.css because of whitelist item {"sourceName":"/\\b(contenteditable|EditorOverride|svg|forms|html|mathml|ua)\\.css$/i","errorMessage":"/Unknown pseudo-class.*-moz-/i","isFromDevTools":false,"used":true}
[task 2018-07-23T09:02:54.433Z] 09:02:54     INFO - Not taking screenshot here: see the one that was previously logged
[task 2018-07-23T09:02:54.435Z] 09:02:54     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_parsable_css.js | Got error message for resource://normandy/skin/shared/Heartbeat.css: Error in parsing value for ‘display’.  Declaration dropped. - 
[task 2018-07-23T09:02:54.436Z] 09:02:54     INFO - Stack trace:
[task 2018-07-23T09:02:54.438Z] 09:02:54     INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_parsable_css.js:messageIsCSSError:243
[task 2018-07-23T09:02:54.439Z] 09:02:54     INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_parsable_css.js:checkAllTheCSS:442
[task 2018-07-23T09:02:54.440Z] 09:02:54     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1103
[task 2018-07-23T09:02:54.442Z] 09:02:54     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1094
[task 2018-07-23T09:02:54.443Z] 09:02:54     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:996
Flags: needinfo?(emilio)

Comment 5

8 months ago
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8d4b97056365
Hide display: -moz-box|-moz-inline-box from content on Nightly and early beta. r=xidorn
(Assignee)

Comment 6

8 months ago
The fact that that test doesn't run on debug try is baffling.
Flags: needinfo?(emilio)
(Assignee)

Comment 9

8 months ago
Test that fails already only on Linux, so my try run didn't catch it... :(
Flags: needinfo?(emilio)

Comment 10

8 months ago
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/mozilla-inbound/rev/599977a50d92
Hide display: -moz-box|-moz-inline-box from content on Nightly and early beta. r=xidorn

Comment 11

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/599977a50d92
Status: NEW → RESOLVED
Last Resolved: 8 months ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Depends on: 1478001

Updated

8 months ago
Blocks: 879275

Updated

7 months ago
Keywords: dev-doc-needed, site-compat → dev-doc-complete

Comment 13

7 months ago
dev docs were already updated. https://github.com/mdn/browser-compat-data/pull/2628 and https://developer.mozilla.org/en-US/docs/Web/CSS/display. That Display page will be overhauled in later this quarter. Let me know if anything else is needed.
Keywords: site-compat
(Assignee)

Updated

6 months ago
Depends on: 1496961
Depends on: 1513914
You need to log in before you can comment on or make changes to this bug.