Open Bug 1477555 Opened 5 years ago Updated 1 year ago

[wpt-sync] Sync PR 12125 - Use generic hasOwnProperty call for asserted objects

Categories

(Testing :: web-platform-tests, enhancement, P4)

Product:
Testing
Component:
web-platform-tests
Type:
enhancement

Tracking

(Not tracked)

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 12125 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/12125
Details from upstream follow.

Arthur Langereis <puurtuur@me.com> wrote:
>  Use generic hasOwnProperty call for asserted objects
>  
>  This fixes issues in the streams tests that call assert_equal and friends on objects explicitly created with a null prototype.  Only the calls to hasOwnProperty on external objects are replaced.
>  
>  Changed in main harness as it (likely?) is not a bad idea to assume other oddly-shaped objects will be passed to the assert functions.
>  
>  The commit making the changes to streams that breaks these fixes is: https://github.com/whatwg/streams/commit/a27a1fd0f8640d6054e0cbc8b6d7f5464dd096ab
The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues
The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.