Closed Bug 1477566 Opened Last year Closed Last year

Avoid recording events in SliceBudget::UnlimitedDeadline

Categories

(Core :: Web Replay, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: bhackett, Assigned: bhackett)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
SliceBudget::UnlimitedDeadline is used during GC and other places where recorded events are not allowed (since they can happen at different places when recording vs. replaying).  This patch avoids recording events under the TimeStamp::Now call made here.

As an aside, this is a rather weird way of calculating an unlimited deadline, and seems to contravene the comment on TimeDuration in TimeStamp.h about arithmetic that involves Forever().
Attachment #8994030 - Flags: review?(sphink)
Comment on attachment 8994030 [details] [diff] [review]
patch

Review of attachment 8994030 [details] [diff] [review]:
-----------------------------------------------------------------

r+ for your patch, and bug 1477761 because I agree that the code seems extremely sketchy.
Attachment #8994030 - Flags: review?(sphink) → review+
Pushed by bhackett@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cbee873889b5
Avoid recording events in SliceBudget::UnlimitedDeadline, r=sfink.
https://hg.mozilla.org/mozilla-central/rev/cbee873889b5
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.