1477566 - Avoid recording events in SliceBudget::UnlimitedDeadline

Status: RESOLVED FIXED

(Core Graveyard :: Web Replay, defect)

Description

[Brian Hackett [Laid off!]]

Attachment: patch

SliceBudget::UnlimitedDeadline is used during GC and other places where recorded events are not allowed (since they can happen at different places when recording vs. replaying).  This patch avoids recording events under the TimeStamp::Now call made here.

As an aside, this is a rather weird way of calculating an unlimited deadline, and seems to contravene the comment on TimeDuration in TimeStamp.h about arithmetic that involves Forever().

Comment 1

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8994030 [details] [diff] [review]
patch

Review of attachment 8994030 [details] [diff] [review]:
-----------------------------------------------------------------

r+ for your patch, and bug 1477761 because I agree that the code seems extremely sketchy.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cbee873889b5
Avoid recording events in SliceBudget::UnlimitedDeadline, r=sfink.

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/cbee873889b5