Closed
Bug 1477608
Opened 6 years ago
Closed 6 years ago
Reuse same ExternalImageId for different video frames if possible
Categories
(Core :: Graphics: WebRender, enhancement)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: sotaro, Assigned: sotaro)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 8 obsolete files)
|
31.62 KB,
patch
|
sotaro
:
review+
nical
:
review+
|
Details | Diff | Splinter Review |
Created by Bug 1474583 Comment 35. Current gecko reuse different ExternalImageId for each video frame. It trigger doc.render() for each webrender frame generation. If we reuse same ExternalImageId for different video frames. We could reduce doc.render() calls.
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → sotaro.ikeda.g
| Comment hidden (obsolete) |
| Comment hidden (obsolete) |
| Comment hidden (obsolete) |
| Comment hidden (obsolete) |
|
|
Assignee | |
Comment 5•6 years ago
|
||
Attachment #8994490 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 6•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=08337edce740b8b89050eb69d67b555faaf2637d
|
|
Assignee | |
Comment 7•6 years ago
|
||
Comment on attachment 8994491 [details] [diff] [review] patch - Reuse same ExternalImageId for different video frames if possible :jrmuizel, can you review the patch? Since :nical is in PTOs.
Attachment #8994491 -
Flags: review?(jmuizelaar)
|
|
Assignee | |
Comment 8•6 years ago
|
||
Attachment #8994491 -
Attachment is obsolete: true
Attachment #8994491 -
Flags: review?(jmuizelaar)
|
|
Assignee | |
Comment 9•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ae561888a1e3ef5d4f527fec8f74fc62118703f4
|
|
Assignee | |
Updated•6 years ago
|
Attachment #8994677 -
Flags: review?(jmuizelaar)
|
|
Assignee | |
Updated•6 years ago
|
Attachment #8994677 -
Flags: review?(jmuizelaar)
|
|
Assignee | |
Comment 10•6 years ago
|
||
(In reply to Sotaro Ikeda [:sotaro] from comment #9) > https://treeherder.mozilla.org/#/ > jobs?repo=try&revision=ae561888a1e3ef5d4f527fec8f74fc62118703f4 It seems that we need to keep WebRenderTextureHostWrapper alive until related wr::Epoch is completed.
|
||
Comment 11•6 years ago
|
||
Comment on attachment 8994677 [details] [diff] [review] patch - Reuse same ExternalImageId for different video frames if possible Review of attachment 8994677 [details] [diff] [review]: ----------------------------------------------------------------- This seems ok to me but I didn't look that closely. Nical should probably still look at it after it lands.
Attachment #8994677 -
Flags: review+
|
|
Assignee | |
Comment 12•6 years ago
|
||
Attachment #8994677 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 13•6 years ago
|
||
(In reply to Jeff Muizelaar [:jrmuizel] from comment #11) > Comment on attachment 8994677 [details] [diff] [review] > patch - Reuse same ExternalImageId for different video frames if possible > > Review of attachment 8994677 [details] [diff] [review]: > ----------------------------------------------------------------- > > This seems ok to me but I didn't look that closely. Nical should probably > still look at it after it lands. Thanks for the review! I will ask :nical for post review.
| Comment hidden (obsolete) |
|
|
Assignee | |
Comment 15•6 years ago
|
||
Fixed HoldExternalImage() calls.
Attachment #8994729 -
Attachment is obsolete: true
Attachment #8994744 -
Flags: review+
|
|
Assignee | |
Comment 16•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=13deeef6fb4bb50f2cadc504213305b509602006&selectedJob=189975958
|
|
Assignee | |
Comment 17•6 years ago
|
||
Addressed debug build problems.
Attachment #8994744 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 18•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=dedfb15384c111fb6bf556c597915699c4aa7067
|
|
Assignee | |
Updated•6 years ago
|
Attachment #8994804 -
Flags: review+
|
||
Comment 19•6 years ago
|
||
Pushed by sikeda@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/7bb705198ab3 Reuse same ExternalImageId for different video frames if possible r=jrmuizel
|
||
Comment 20•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/7bb705198ab3
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
|
|
Assignee | |
Comment 21•6 years ago
|
||
Comment on attachment 8994804 [details] [diff] [review] patch - Reuse same ExternalImageId for different video frames if possible :nical, can you do post-review the patch?
Attachment #8994804 -
Flags: review?(nical.bugzilla)
|
||
Comment 22•6 years ago
|
||
Comment on attachment 8994804 [details] [diff] [review] patch - Reuse same ExternalImageId for different video frames if possible Review of attachment 8994804 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/webrender_bindings/RenderTextureHostWrapper.h @@ +12,5 @@ > +namespace mozilla { > + > +namespace wr { > + > +class RenderTextureHostWrapper final : public RenderTextureHost It'd be nice to have a comment here explaining what the wrapper is for.
Attachment #8994804 -
Flags: review?(nical.bugzilla) → review+
|
|
Assignee | |
Comment 23•6 years ago
|
||
Thanks. I am going to add a comment.
|
||
Comment 24•6 years ago
|
||
(In reply to Pulsebot from comment #19) > Pushed by sikeda@mozilla.com: > https://hg.mozilla.org/integration/mozilla-inbound/rev/7bb705198ab3 > Reuse same ExternalImageId for different video frames if possible r=jrmuizel Could this patch have caused bug 1479175? All crashes contain WR+.
You need to log in
before you can comment on or make changes to this bug.
Description
•