Closed
Bug 1477632
Opened 3 years ago
Closed 3 years ago
Always inline PLDHashTable::SearchTable()
Categories
(Core :: XPCOM, enhancement)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
Details
Attachments
(1 file)
It's super hot.
Comment hidden (mozreview-request) |
![]() |
||
Comment 2•3 years ago
|
||
mozreview-review |
Comment on attachment 8994118 [details] Bug 1477632 - Always inline PLDHashTable::SearchTable(). https://reviewboard.mozilla.org/r/258738/#review265682
Attachment #8994118 -
Flags: review?(nfroyd) → review+
Pushed by nnethercote@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5da2166fd301 Always inline PLDHashTable::SearchTable(). r=froydnj
![]() |
||
Comment 4•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5da2166fd301
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
![]() |
Assignee | |
Comment 5•3 years ago
|
||
Perfherder results are here: https://treeherder.mozilla.org/perf.html#/graphs?series=mozilla-inbound,1730062,1,6&series=mozilla-central,1730148,1,6&series=mozilla-central,1730117,1,6&series=mozilla-central,1730160,1,6&series=mozilla-central,1730172,1,6 It's a clear win on linux32, but didn't appear to have much effect on other platforms. (Locally, it was a clear win on linux64 for me.)
You need to log in
before you can comment on or make changes to this bug.
Description
•