Closed Bug 1477633 Opened 7 years ago Closed 7 years ago

Add title to snippets block button in AS Router

Categories

(Firefox :: New Tab Page, enhancement, P1)

Product:
Firefox
Component:
New Tab Page
Type:
enhancement

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 64
Iteration:
64.3 - Oct 12
Tracking Flags:
Tracking Status
firefox64 --- verified

People

(Reporter: giorgos, Assigned: andreio)

References

Details

(Keywords: access, Whiteboard: [strings needed])

Attachments

(1 file)

Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4462
52 bytes, text/x-github-pull-request
Details | Review
Block button in AS Router snippets should have a `title` attribute set to `Remove this` and be translatable to the Activity Stream's language (which i guess matches chrome's language)
Iteration: --- → 63.3 - Aug 6
Keywords: access
Priority: -- → P1
Whiteboard: [strings needed]
Assignee: nobody → andrei.br92
Iteration: 63.3 - Aug 6 → ---
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Blocks: 1496457
https://hg.mozilla.org/mozilla-central/rev/4a0b6cfb51a1
Iteration: --- → 64.3 (Oct 12)
status-firefox64: --- → fixed
Target Milestone: --- → Firefox 64
I have verified this issue with the latest "Firefox Nightly" build (64.0a1 - Build ID 20181011220118) installed, on Windows 10 x64, Arch Linux and Mac 10.13.3, and I can confirm that the "Remove this" tooltip is displayed for the "Dismiss" button if hovered.
Status: RESOLVED → VERIFIED
status-firefox64: fixed → verified
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: