Closed Bug 1477651 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 12141 - webrtc: make transceiver tests work in Firefox

Categories

(Core :: WebRTC, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 12141 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/12141
Details from upstream follow.

Philipp Hancke <fippo@andyet.net> wrote:
>  webrtc: make transceiver tests work in Firefox
>  
>  makes most new transceiver tests pass by avoiding addTrack(track) which does not work in Firefox yet.
>  
>  @henbos PTAL
>  
>  @alvestrand @foolip it would be great if you folks ran the tests in Firefox at least once before pushing them and/or asked whether that was done during review. Most things that did not work in Firefox were easy to avoid. The `setRemoteDescription(offer): ontrack's track.id is the same as track.id` fails in Firefox but that is ok, the spec does *NOT* require this.
PR 12141 applied with additional changes from upstream: 64689609bd77dfdfad8aa69a9477509e42c8613f
Component: web-platform-tests → WebRTC
Product: Testing → Core
Ran 1 tests and 41 subtests
OK     : 1
PASS   : 35
FAIL   : 6

New tests that have failures or other problems:
/webrtc/RTCPeerConnection-transceivers.https.html
    Closing the PC stops the transceivers: FAIL
    addTrack(0 streams): ontrack fires with no stream: FAIL
    addTrack(2 streams): ontrack fires with corresponding two streams: FAIL
    addTransceiver(2 streams): ontrack fires with corresponding two streams: FAIL
    addTransceiver(track, init): initialize sendEncodings[0].active to false: FAIL
    setRemoteDescription(offer): ontrack's track.id is the same as track.id: FAIL
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/975a484ef255
[wpt PR 12141] - webrtc: make transceiver tests work in Firefox, a=testonly
https://hg.mozilla.org/mozilla-central/rev/975a484ef255
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.