Closed
Bug 1477672
Opened 6 years ago
Closed 6 years ago
Migrate existing live bookmarks in order to keep user data
Categories
(Firefox :: Bookmarks & History, enhancement, P1)
Firefox
Bookmarks & History
Tracking
()
RESOLVED
FIXED
Firefox 64
People
(Reporter: Gijs, Assigned: Gijs)
References
()
Details
(Whiteboard: [overhead:noted])
Attachments
(1 file)
Once we stop allowing the creation of new live bookmarks, we can implement a migration step that removes any existing ones (creating "normal" ones if we have a site URL) and exports a backup file.
Updated•6 years ago
|
Priority: -- → P1
Updated•6 years ago
|
Whiteboard: [overhead:noted]
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•6 years ago
|
||
Patch incoming. Consider the review request more a 'feedback' one (I know that at the very least it would be good to also have an automated test for some of this stuff), but phabricator doesn't support making that explicit.
Assignee | ||
Updated•6 years ago
|
status-firefox64:
--- → affected
Assignee | ||
Comment 2•6 years ago
|
||
Assignee | ||
Comment 3•6 years ago
|
||
Caitlin, we'd like to open a SUMO page in Firefox when migration has happened. I was thinking we'd use the page you started, ie https://support.mozilla.org/en-US/kb/feed-reader-replacements-firefox . We'd likely want to add some content near the top explaining that we've converted the users' live bookmarks into "normal" bookmarks pointing to the website from which the feed was bookmarked, and that we've created an OPML backup file on the user's desktop. Does that sound OK, or do you think it'd be clearer to have a separate SUMO page with that content that links to the 'feed reader replacements' page?
Flags: needinfo?(cneiman)
Comment 4•6 years ago
|
||
Hey Gijs! I got a little bit more involved in this than I should have, so I'm going to turn this over to the experts. :) Joni Savage, Content Manager for SUMO, can help you out with creating an in-product link. She can also help advise you about content strategy. (She is also very lovely to work with -- you are in good hands!) Joni, can you work with Gijs (who is also very lovely!) on this piece of the feed reader replacement project? Thanks!
Flags: needinfo?(cneiman) → needinfo?(jsavage)
Thanks for the needinfo! Gijs, I suggest we make a separate SUMO page specifically about the migration so users wouldn't be overwhelmed with information. Another advantage to making a separate SUMO page is that we set up the existing article to come up in search so it wouldn't make sense to show the migration message to people arriving from search. Here's a link you can use in-product: https://support.mozilla.org/1/firefox/%VERSION%/%OS%/%LOCALE%/live-bookmarks-migration I've also started a rough draft in Google Docs. https://docs.google.com/document/d/1689BkZBNhLGsRF2Dy-D0ofnPdxN2aty0THO0qiFTC2o/edit?usp=sharing Please comment with any changes/corrections.
Flags: needinfo?(jsavage) → needinfo?(gijskruitbosch+bugs)
Comment 6•6 years ago
|
||
Comment on attachment 9009690 [details] Bug 1477672 - export and convert existing live bookmarks to avoid losing user data, r?mak Marco Bonardo [::mak] has approved the revision.
Attachment #9009690 -
Flags: review+
Assignee | ||
Comment 7•6 years ago
|
||
(In reply to Joni Savage ("need info" me) from comment #5) > Thanks for the needinfo! > > Gijs, I suggest we make a separate SUMO page specifically about the > migration so users wouldn't be overwhelmed with information. OK, makes sense. > Another advantage to making a separate SUMO page is that we set up the > existing article to come up in search so it wouldn't make sense to show the > migration message to people arriving from search. > > Here's a link you can use in-product: > https://support.mozilla.org/1/firefox/%VERSION%/%OS%/%LOCALE%/live-bookmarks- > migration Thanks! > I've also started a rough draft in Google Docs. > https://docs.google.com/document/d/1689BkZBNhLGsRF2Dy- > D0ofnPdxN2aty0THO0qiFTC2o/edit?usp=sharing > > Please comment with any changes/corrections. Thanks, I've left a few comments. Marco, can you also take a look?
Flags: needinfo?(gijskruitbosch+bugs) → needinfo?(mak77)
Comment 8•6 years ago
|
||
I agree with previous comments, and added a couple more thoughts.
Flags: needinfo?(mak77)
Thanks for feedback on the article. I've incorporated your feedback in the doc: https://docs.google.com/document/d/1689BkZBNhLGsRF2Dy-D0ofnPdxN2aty0THO0qiFTC2o/edit?usp=sharing Please take another look and let us know if we should go ahead and publish. Will there be a doorhanger or some sort of UI indicator that the bookmarks have been converted so the user isn't surprised?
Flags: needinfo?(gijskruitbosch+bugs)
Assignee | ||
Comment 10•6 years ago
|
||
(In reply to Joni Savage ("need info" me) from comment #9) > Thanks for feedback on the article. I've incorporated your feedback in the > doc: > https://docs.google.com/document/d/1689BkZBNhLGsRF2Dy- > D0ofnPdxN2aty0THO0qiFTC2o/edit?usp=sharing > > Please take another look and let us know if we should go ahead and publish. Marco's already left some more comments. > Will there be a doorhanger or some sort of UI indicator that the bookmarks > have been converted so the user isn't surprised? We intend to open this SUMO page in a new (selected) tab automatically when the user updates to a release where there is no more support *and* if they had 1 or more live bookmarks. There won't be other notifications besides opening this tab.
Flags: needinfo?(gijskruitbosch+bugs) → needinfo?(jsavage)
Comment 11•6 years ago
|
||
Thanks, I fixed the error in the content and updated the article now.
Flags: needinfo?(jsavage)
Comment 12•6 years ago
|
||
I made some other revisions - see https://support.mozilla.org/kb/live-bookmarks-migration/history
QA Contact: mak77
Assignee | ||
Comment 13•6 years ago
|
||
(In reply to Alice Wyman from comment #12) > I made some other revisions - see > https://support.mozilla.org/kb/live-bookmarks-migration/history Looks great, thank you!
Updated•6 years ago
|
QA Contact: mak77
Assignee | ||
Comment 14•6 years ago
|
||
Trypush looked effectively green: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1baa360153801d9174c63b4c2b018ae966a64e36&selectedJob=203672105 Another trypush that I just kicked off with this + bug 1477671, given we want to land all of these fixes together: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c38b715c4d7fbcb22f58916cc9c364b1bac4b7dd (We probably want to land this late Sunday / early on Monday to avoid having to deal with fallout over the weekend should there be any - of course we hope/assume there isn't, but this is effectively the m-c version of "don't deploy on Friday".)
Comment 15•6 years ago
|
||
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/2cd029293041 export and convert existing live bookmarks to avoid losing user data, r=mak
Comment 16•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2cd029293041
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
You need to log in
before you can comment on or make changes to this bug.
Description
•