1477691 - 0.19% installer size (osx-cross) regression on push b17cfac5aa3f0159ce781666aecc9976d566c276 (Sun Jul 22 2018)

Status: RESOLVED WONTFIX

(Core Graveyard :: Web Replay, defect)

Description

[Ionuț Goldan [:igoldan]]

We have detected a build metrics regression from push:

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?changeset=b17cfac5aa3f0159ce781666aecc9976d566c276

As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

  >100KBytes  installer size osx-cross opt      66,488,736.88 -> 66,613,595.17


You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=14484

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the jobs in a pushlog format.

To learn more about the regressing test(s), please see: https://developer.mozilla.org/en-US/docs/Mozilla/Performance/Automated_Performance_Testing_and_Sheriffing/Build_Metrics

Comment 1

[Brian Hackett [Laid off!]]

Hi, this push adds the code used for Web Replay, a significant new feature.  I don't think an increase in the installer size is avoidable.  This code is only compiled on Mac nightlies for now, per toolkit/recordreplay/moz.build.

Comment 2

[Ionuț Goldan [:igoldan]]

The patch is composed of 3 bugs: bug 1207696, bug 1465452 and bug 1465470. For posterity, which one is related to this installer size increase?

Comment 3

[Brian Hackett [Laid off!]]

I think the Web Replay tracking bug, bug 1422587, would be most appropriate.  The new code is spread across a number of its dependent bugs.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

give bug 1477905 is wontfix marking this the same