Closed
Bug 1477708
Opened 7 years ago
Closed 7 years ago
Make theme loading part of the Theme constructor in ext-theme.js
Categories
(WebExtensions :: Themes, defect)
WebExtensions
Themes
Tracking
(firefox63 fixed)
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: ntim, Assigned: ntim)
References
Details
(Whiteboard: [ntim-intern-project])
Attachments
(1 file)
With bug 1347207, I'll start doing some async stuff in the constructor before actually loading the theme, so this will make the work easier for me.
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8994200 [details]
Bug 1477708 - Make theme loading part of the Theme constructor in ext-theme.js.
https://reviewboard.mozilla.org/r/258796/#review265696
Code analysis found 1 defect in this patch:
- 1 defect found by mozlint
You can run this analysis locally with:
- `./mach lint path/to/file` (JS/Python)
If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx
::: toolkit/components/extensions/parent/ext-theme.js:334
(Diff revision 1)
> return;
> }
>
> - defaultTheme = new Theme(extension);
> - defaultTheme.load(manifest.theme);
> + defaultTheme = new Theme({
> + extension,
> + details: manifest.theme
Error: Missing trailing comma. [eslint: comma-dangle]
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → ntim.bugs
Comment hidden (mozreview-request) |
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8994200 [details]
Bug 1477708 - Make theme loading part of the Theme constructor in ext-theme.js.
https://reviewboard.mozilla.org/r/258796/#review265826
Attachment #8994200 -
Flags: review?(jaws) → review+
Comment 5•7 years ago
|
||
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.
hg error in cmd: hg rebase -s 325aedb56a74c03067889368d56b1c005fbe3b8b -d 69500fda8331: rebasing 473992:325aedb56a74 "Bug 1477708 - Make theme loading part of the Theme constructor in ext-theme.js. r=jaws" (tip)
merging toolkit/components/extensions/parent/ext-theme.js
warning: conflicts while merging toolkit/components/extensions/parent/ext-theme.js! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Comment hidden (mozreview-request) |
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/2ccf3971a466
Make theme loading part of the Theme constructor in ext-theme.js. r=jaws
Comment 8•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Comment 9•7 years ago
|
||
Is manual testing required on this bug? If yes, please provide some STR and the proper extension(if required) or set the “qe-verify -“ flag.
Thanks!
Flags: needinfo?(ntim.bugs)
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(ntim.bugs) → qe-verify-
Assignee | ||
Updated•7 years ago
|
Whiteboard: [ntim-intern-project]
You need to log in
before you can comment on or make changes to this bug.
Description
•