Closed Bug 1477724 Opened 6 years ago Closed 6 years ago

"Move to New Window" moves active tab instead of right-clicked

Categories

(Firefox :: Tabbed Browser, defect)

Product:
Firefox
Component:
Tabbed Browser
Version:
63 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 63
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- unaffected
firefox61 --- unaffected
firefox62 --- unaffected
firefox63 --- verified

People

(Reporter: winson.wen1, Assigned: ablayelyfondou)

References

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1477724 - 'Move To New Window' moves now contextTab instead of selectedTab in single tab context.
59 bytes, text/x-review-board-request
jaws
: review+
Details 
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:63.0) Gecko/20100101 Firefox/63.0
Build ID: 20180723100101

Steps to reproduce:

Have multiple tabs open
Right-click on a background tab
Select Move to New Window


Actual results:

Active tab was moved


Expected results:

Right-clicked tab was moved
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:63.0) Gecko/20100101 Firefox/63.0
20180723100101

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=1fafb8e07051ccf79a2fa5364d334baa7ac83f10&tochange=61a9c158562072559c3b8447d6b4d27469d4a650
Blocks: 1458049
Status: UNCONFIRMED → NEW
Has Regression Range: --- → yes
Has STR: --- → yes
Component: Untriaged → Tabbed Browser
Ever confirmed: true
Flags: needinfo?(ablayelyfondou)
Keywords: regression
Assignee: nobody → ablayelyfondou
Flags: needinfo?(ablayelyfondou)
Thank you for catching this. I attached a patch and Jared should push it soon.
Flags: needinfo?(jaws)
Status: NEW → ASSIGNED
Comment on attachment 8994323 [details]
Bug 1477724 - 'Move To New Window' moves now contextTab instead of selectedTab in single tab context.

https://reviewboard.mozilla.org/r/258918/#review265896
Attachment #8994323 - Flags: review?(jaws) → review+
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8e9f2c8a1bd8
'Move To New Window' moves now contextTab instead of selectedTab in single tab context. r=jaws
https://hg.mozilla.org/mozilla-central/rev/8e9f2c8a1bd8
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
I have reproduced this bug with Nightly 63.0a1 (2018-07-23) on Windows 10, 64 Bit!
This bug's fix is verified with latest Nightly!

Build ID 	20180730100211
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:63.0) Gecko/20100101 Firefox/63.0
QA Whiteboard: [bugday-20180725]
Flags: needinfo?(jaws)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: