Closed
Bug 1477744
Opened 6 years ago
Closed 6 years ago
Re-enable -Werror in clang-cl for Spidermonkey
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox63 fixed)
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: away, Assigned: away)
References
Details
Attachments
(1 file)
|
2.87 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
While we're still far from finished on bug 1090497, Spidermonkey is already Werror-clean with clang-cl, except for one issue at bug 1477742, so we should go ahead and re-enable Werror there once that one bug is fixed.
This patch makes it so that we disable -Werror in old-configure.in (and deliberately not js/src/old-configure.in) rather than context.py.
I've also removed clang-cl from an ancient MSVC PGO workaround codepath.
Assignee: nobody → dmajor
Attachment #8994236 -
Flags: review?(core-build-config-reviews)
|
||
Updated•6 years ago
|
Attachment #8994236 -
Flags: review?(core-build-config-reviews) → review+
Pushed by dmajor@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/707eaef32a63
Re-enable -Werror in clang-cl for Spidermonkey. r=froydnj
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•