Closed Bug 1477744 Opened Last year Closed Last year

Re-enable -Werror in clang-cl for Spidermonkey

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox63 fixed)

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: dmajor, Assigned: dmajor)

References

Details

Attachments

(1 file)

While we're still far from finished on bug 1090497, Spidermonkey is already Werror-clean with clang-cl, except for one issue at bug 1477742, so we should go ahead and re-enable Werror there once that one bug is fixed.
This patch makes it so that we disable -Werror in old-configure.in (and deliberately not js/src/old-configure.in) rather than context.py.

I've also removed clang-cl from an ancient MSVC PGO workaround codepath.
Assignee: nobody → dmajor
Attachment #8994236 - Flags: review?(core-build-config-reviews)
Attachment #8994236 - Flags: review?(core-build-config-reviews) → review+
Pushed by dmajor@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/707eaef32a63
Re-enable -Werror in clang-cl for Spidermonkey. r=froydnj
https://hg.mozilla.org/mozilla-central/rev/707eaef32a63
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.