1477792 - Enable mac taskcluster build for searchfox

Status: RESOLVED FIXED

(Webtools :: Searchfox, enhancement)

Description

[Kartikaya Gupta (email:[e-mail])]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=dc9ec3b96acc62598da7319b289d987227649124

It works now, we should turn it on to prevent it from regressing. Also it will make a Real Incentive (TM) to fix bug 1425597 because it will produce actual advantages in that we can index code that is behind macOS compile guards.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1477792 - Save the rust-analysis on macOS searchfox builds.

This is the equivalent of bug 1432475 but for macOS.

Review commit: https://reviewboard.mozilla.org/r/258862/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/258862/

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1477792 - Run daily macOS searchfox builds.

Review commit: https://reviewboard.mozilla.org/r/258864/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/258864/

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8994276 [details]
Bug 1477792 - Save the rust-analysis on macOS searchfox builds.

https://reviewboard.mozilla.org/r/258862/#review265820

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8994277 [details]
Bug 1477792 - Run daily macOS searchfox builds.

https://reviewboard.mozilla.org/r/258864/#review265822

This looks fine, though maybe you need someone else to get more jobs running on CI?

In any case, the code change itself is trivial, so feel free to land if you're confident about that :)

Comment 5

[Kartikaya Gupta (email:[e-mail])]

It's a tier-2 job so I don't think I need anybody else to sign off on this. I've added jobs before like this and nobody has complained, so I'll assume it's fine.. :)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/778572e3e6bc
Save the rust-analysis on macOS searchfox builds. r=emilio
https://hg.mozilla.org/integration/autoland/rev/df1e31672e14
Run daily macOS searchfox builds. r=emilio

Comment 7

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/778572e3e6bc
https://hg.mozilla.org/mozilla-central/rev/df1e31672e14