Closed
Bug 1477793
Opened 6 years ago
Closed 6 years ago
Hidden tabs are displayed in the wrong spot in the all tabs menu
Categories
(Firefox :: Tabbed Browser, defect, P1)
Firefox
Tabbed Browser
Tracking
()
VERIFIED
FIXED
Firefox 63
Tracking | Status | |
---|---|---|
firefox63 | --- | verified |
People
(Reporter: mstriemer, Assigned: mstriemer)
References
Details
Attachments
(4 files)
The ids of the separators changed and now audio playing hidden tabs are shown above the Hidden Tabs menu separator instead of after the submenu entry.
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•6 years ago
|
||
Assignee | ||
Comment 3•6 years ago
|
||
Comment 4•6 years ago
|
||
mozreview-review |
Comment on attachment 8994290 [details] Bug 1477793 - Show hidden audio tabs after Hidden Tabs https://reviewboard.mozilla.org/r/258872/#review266034 ::: browser/base/content/browser-allTabsMenu.js:38 (Diff revision 1) > if (this._initialized) return; > > this.initElements(); > > let hiddenTabsMenuButton = document.getElementById("allTabsMenu-hiddenTabsButton"); > let hiddenTabsSeparator = document.getElementById("allTabsMenu-hiddenTabsSeparator"); Move these two down into the ViewShowing handler? ::: browser/base/content/browser-allTabsMenu.js:42 (Diff revision 1) > let hiddenTabsMenuButton = document.getElementById("allTabsMenu-hiddenTabsButton"); > let hiddenTabsSeparator = document.getElementById("allTabsMenu-hiddenTabsSeparator"); > + let tabsSeparator = document.getElementById("allTabsMenu-tabsSeparator"); > this.hiddenAudioTabsPopup = new TabsPanel({ > view: this.allTabsView, > - insertBefore: hiddenTabsSeparator, > + insertBefore: tabsSeparator, Could just write this as: insertBefore: document.getElementById("allTabsMenu-tabsSeparator"),
Attachment #8994290 -
Flags: review?(dao+bmo) → review+
Updated•6 years ago
|
Priority: -- → P1
Comment hidden (mozreview-request) |
Pushed by mstriemer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/142b78b61216 Show hidden audio tabs after Hidden Tabs r=dao
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/142b78b61216
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
This issue is verified as fixed on Firefox 63.0a1 (20180731105217) under Win 7 64-bit and Mac OS X 10.13.3. Please see the attached video.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•