1477815 - Remove RustSdpAttributeType

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, enhancement, P2)

Description

[Johannes Willbold]

Remove the RustSdpAttributeType enum in the rsdparsa capi and use SdpAttributeType  instead. They are completely similar and thus there is no reason to have two of them.

Comment 1

[Johannes Willbold]

Attachment: Bug 1477815: Removed RustSdpAttributeType,

Removed the enum RustSdpAttributeType and replaced it with the SdpAttributeType enum.

Review commit: https://reviewboard.mozilla.org/r/258922/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/258922/

Comment 2

[Dan Minor [:dminor]]

Comment on attachment 8994332 [details]
Bug 1477815: Removed RustSdpAttributeType,

https://reviewboard.mozilla.org/r/258922/#review266138

lgtm

Comment 3

[Mozilla Autoland]

(255, 'comparing with ssh://hg.mozilla.org/integration/autoland\nremote: Permission denied (publickey).', 'abort: no suitable response from remote hg!')

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7c66524457aa
Removed RustSdpAttributeType, r=dminor

Comment 5

[Raul Gurzau (:RaulG)]

Backed out changeset 7c66524457aa (bug 1477815) for build bustage at toolkit/library/gtest/rust/target on a CLOSED TREE

Backout link: https://hg.mozilla.org/integration/autoland/rev/e837adf72daaf9c76eae4ff21b61bd74e85ba09a

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=7c66524457aad6bff06e4b6e6cbd635171c5dc28

Log link: https://treeherder.mozilla.org/logviewer.html#?job_id=190363603&repo=autoland&lineNumber=12743

Log snippet: 

[task 2018-07-26T20:10:07.952Z] 20:10:07     INFO -  warning: use of deprecated item 'futures::task::Unpark::unpark': recommended to use `Notify` instead
[task 2018-07-26T20:10:07.953Z] 20:10:07     INFO -     --> third_party/rust/tokio-core/src/reactor/mod.rs:570:34
[task 2018-07-26T20:10:07.953Z] 20:10:07     INFO -      |
[task 2018-07-26T20:10:07.953Z] 20:10:07     INFO -  570 |         entry.get().wake.clone().unpark();
[task 2018-07-26T20:10:07.953Z] 20:10:07     INFO -      |                                  ^^^^^^
[task 2018-07-26T20:10:07.953Z] 20:10:07     INFO -  warning: use of deprecated item '<futures::sync::mpsc::UnboundedSender<T>>::send': renamed to `unbounded_send`
[task 2018-07-26T20:10:07.954Z] 20:10:07     INFO -     --> third_party/rust/tokio-core/src/reactor/mod.rs:585:27
[task 2018-07-26T20:10:07.954Z] 20:10:07     INFO -      |
[task 2018-07-26T20:10:07.954Z] 20:10:07     INFO -  585 |                     match mpsc::UnboundedSender::send(&self.tx, msg) {
[task 2018-07-26T20:10:07.954Z] 20:10:07     INFO -      |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[task 2018-07-26T20:10:07.954Z] 20:10:07     INFO -  warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead
[task 2018-07-26T20:10:07.955Z] 20:10:07     INFO -   --> third_party/rust/url/src/parser.rs:9:5
[task 2018-07-26T20:10:07.955Z] 20:10:07     INFO -    |
[task 2018-07-26T20:10:07.955Z] 20:10:07     INFO -  9 | use std::ascii::AsciiExt;
[task 2018-07-26T20:10:07.955Z] 20:10:07     INFO -    |     ^^^^^^^^^^^^^^^^^^^^
[task 2018-07-26T20:10:07.955Z] 20:10:07     INFO -    |
[task 2018-07-26T20:10:07.955Z] 20:10:07     INFO -    = note: #[warn(deprecated)] on by default
[task 2018-07-26T20:10:07.955Z] 20:10:07     INFO -  warning: unused import: `std::ascii::AsciiExt`
[task 2018-07-26T20:10:07.956Z] 20:10:07     INFO -   --> third_party/rust/url/src/parser.rs:9:5
[task 2018-07-26T20:10:07.956Z] 20:10:07     INFO -    |
[task 2018-07-26T20:10:07.956Z] 20:10:07     INFO -  9 | use std::ascii::AsciiExt;
[task 2018-07-26T20:10:07.956Z] 20:10:07     INFO -    |     ^^^^^^^^^^^^^^^^^^^^
[task 2018-07-26T20:10:07.956Z] 20:10:07     INFO -    |
[task 2018-07-26T20:10:07.956Z] 20:10:07     INFO -    = note: #[warn(unused_imports)] on by default
[task 2018-07-26T20:10:07.957Z] 20:10:07     INFO -  error: build failed
[task 2018-07-26T20:10:07.957Z] 20:10:07     INFO -  /builds/worker/workspace/build/src/config/rules.mk:971: recipe for target 'force-cargo-library-build' failed
[task 2018-07-26T20:10:07.957Z] 20:10:07     INFO -  make[4]: *** [force-cargo-library-build] Error 101
[task 2018-07-26T20:10:07.958Z] 20:10:07     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/library/gtest/rust'
[task 2018-07-26T20:10:07.958Z] 20:10:07     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/media/libvpx'
[task 2018-07-26T20:10:07.958Z] 20:10:07     INFO -  /builds/worker/workspace/build/src/config/recurse.mk:74: recipe for target 'toolkit/library/gtest/rust/target' failed
[task 2018-07-26T20:10:07.958Z] 20:10:07     INFO -  make[3]: *** [toolkit/library/gtest/rust/target] Error 2
[task 2018-07-26T20:10:07.959Z] 20:10:07     INFO -  make[3]: *** Waiting for unfinished jobs....

Comment 6

[Johannes Willbold]

The merge with bug 1476085 malformed the code. Fixed it.

Comment 7

[Johannes Willbold]

Comment on attachment 8994332 [details]
Bug 1477815: Removed RustSdpAttributeType,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/258922/diff/1-2/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5acc7afc8c95
Removed RustSdpAttributeType, r=dminor

Comment 9

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/5acc7afc8c95