Closed Bug 1477825 Opened 7 years ago Closed 7 years ago

Clean up static analysis findings in PeerConnectionImpl.cpp

Categories

(Core :: WebRTC, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: ng, Assigned: ng)

Details

Attachments

(1 file)

Static analysis finds a small number of places where const references could be used. We should fix those.
Static analysis reveals that there are several places we could be using const references in PeerConnectionImp. This patch addresses all of those places.
Comment on attachment 8994327 [details] Bug 1477825 - PeerConnectionImpl static analysis const reference cleanup Michael Froman [:mjf] has approved the revision. https://phabricator.services.mozilla.com/D2304
Attachment #8994327 - Flags: review+
Comment on attachment 8994327 [details] Bug 1477825 - PeerConnectionImpl static analysis const reference cleanup Jan-Ivar Bruaroey [:jib] (needinfo? me) has approved the revision. https://phabricator.services.mozilla.com/D2304
Attachment #8994327 - Flags: review+
Pushed by na-g@nostrum.com: https://hg.mozilla.org/integration/autoland/rev/c79c7af9fa0e PeerConnectionImpl static analysis const reference cleanup r=mjf,jib
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: